Closed
Bug 934332
Opened 11 years ago
Closed 11 years ago
Don't install tests under js/src in --with-libxul-sdk builds
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(firefox26 unaffected, firefox27 fixed, firefox28 fixed)
RESOLVED
FIXED
mozilla28
Tracking | Status | |
---|---|---|
firefox26 | --- | unaffected |
firefox27 | --- | fixed |
firefox28 | --- | fixed |
People
(Reporter: glandium, Assigned: glandium)
References
Details
(Whiteboard: [qa-])
Attachments
(1 file)
1.42 KB,
patch
|
gps
:
review+
bajaj
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•11 years ago
|
||
Attachment #826585 -
Flags: review?(gps)
Assignee | ||
Updated•11 years ago
|
status-firefox26:
--- → unaffected
status-firefox27:
--- → affected
Updated•11 years ago
|
Attachment #826585 -
Flags: review?(gps) → review+
Assignee | ||
Comment 2•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/a356d5b03317
Comment 3•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/a356d5b03317
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
Assignee | ||
Comment 4•11 years ago
|
||
Comment on attachment 826585 [details] [diff] [review] Don't install tests under js/src in --with-libxul-sdk builds [Approval Request Comment] Bug caused by (feature/regressing bug #): bug 862770 User impact if declined: Breaks building with --with-libxul-sdk (option used by at least fedora and debian). Testing completed (on m-c, etc.): Landed on m-c a few days ago. Risk to taking this patch (and alternatives if risky): Doesn't change anything for mozilla.org builds. I've been using this patch for a while on debian. String or IDL/UUID changes made by this patch: None
Attachment #826585 -
Flags: approval-mozilla-aurora?
Comment 5•11 years ago
|
||
(In reply to Mike Hommey [:glandium] from comment #4) > Comment on attachment 826585 [details] [diff] [review] > Don't install tests under js/src in --with-libxul-sdk builds > > [Approval Request Comment] > Bug caused by (feature/regressing bug #): bug 862770 https://bugzilla.mozilla.org/show_bug.cgi?id=862770 seems to have landed on Fx28 so unclear how Fx27 is affected by that bug, can you help ? > User impact if declined: Breaks building with --with-libxul-sdk (option used > by at least fedora and debian). > Testing completed (on m-c, etc.): Landed on m-c a few days ago. > Risk to taking this patch (and alternatives if risky): Doesn't change > anything for mozilla.org builds. I've been using this patch for a while on > debian. > String or IDL/UUID changes made by this patch: None
Assignee | ||
Comment 6•11 years ago
|
||
(In reply to bhavana bajaj [:bajaj] from comment #5) > (In reply to Mike Hommey [:glandium] from comment #4) > > Comment on attachment 826585 [details] [diff] [review] > > Don't install tests under js/src in --with-libxul-sdk builds > > > > [Approval Request Comment] > > Bug caused by (feature/regressing bug #): bug 862770 > > https://bugzilla.mozilla.org/show_bug.cgi?id=862770 seems to have landed on > Fx28 so unclear how Fx27 is affected by that bug, can you help ? Err, that was the wrong bug number. The right one is bug 911375. Sorry for the confusion.
Updated•11 years ago
|
Attachment #826585 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment 7•11 years ago
|
||
(In reply to Mike Hommey [:glandium] from comment #6) > (In reply to bhavana bajaj [:bajaj] from comment #5) > > (In reply to Mike Hommey [:glandium] from comment #4) > > > Comment on attachment 826585 [details] [diff] [review] > > > Don't install tests under js/src in --with-libxul-sdk builds > > > > > > [Approval Request Comment] > > > Bug caused by (feature/regressing bug #): bug 862770 > > > > https://bugzilla.mozilla.org/show_bug.cgi?id=862770 seems to have landed on > > Fx28 so unclear how Fx27 is affected by that bug, can you help ? > > Err, that was the wrong bug number. The right one is bug 911375. Sorry for > the confusion. Thanks for the clarification, looks good to land.
Comment 8•11 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/8913df97d957
status-firefox28:
--- → fixed
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•