934568 - Make cycle collector OOM assertions fatal in debug builds

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Andrew McCreight [:mccr8]]

See: https://hg.mozilla.org/integration/mozilla-inbound/rev/338760b1955c

Maybe this aren't permaorange any more.

https://tbpl.mozilla.org/?tree=Try&rev=3cbca430422e

Comment 1

[Andrew McCreight [:mccr8]]

Attachment: bjacob's patch

This looked green on try, so I'll land this when inbound is open again.

Comment 2

[Andrew McCreight [:mccr8]]

Here goes...

https://hg.mozilla.org/integration/mozilla-inbound/rev/e078b92f7db1

Comment 3

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/e078b92f7db1

Comment 4

[Andrew McCreight [:mccr8]]

Attachment: make the ScanRoots assertion non-fatal, fix indentation

This is triggering quite a bit on Win7 debug M2 for whatever reason, and I don't have any time to look into it this week, so let's just avoid bothering the sheriffs.

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

Do you have log links to the failures?

Comment 6

[Andrew McCreight [:mccr8]]

I should have said, the failures are in bug 935419.

Comment 7

[Andrew McCreight [:mccr8]]

Thanks for the fast review!
https://hg.mozilla.org/integration/mozilla-inbound/rev/1426425fc177

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/1426425fc177