934703 - Plugincheck Farsi page broken

Status: VERIFIED FIXED

(www.mozilla.org :: Pages & Content, defect)

Description

[raymond [:retornam] (inactive)]

STR:
1) Visit the newly activated https://www.allizom.org/fa/plugincheck/page
2)Notice that the bolder text overlaps the smaller one in some areas. See attached screenshot

Comment 1

[raymond [:retornam] (inactive)]

Attachment: Screen Shot 2013-11-04 at 2.59.59 PM.png

Comment 2

[Craig Cook (:craigcook)]

The button is absolutely positioned to the right, but when the direction is RTL, the button just overlaps the text. One fix would be to pad the container and reserve space for the button, and even better would be to position the button on the left side for RTL languages. I'll have a PR in shortly.

Comment 3

[Francesco Lodolo [:flod]]

Ouch, I never realized there was a download button for non Firefox browsers :-\

This obviously affects other RTL locales
https://www.allizom.org/he/plugincheck/

Comment 4

[[github robot]]

Commits pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/38d124dc79376316ffb43bd8f9f2a41c4f3f8305
fix bug 934703 - layout fixes for rtl languages

Comprising some minor global layout fixes (just the header) as well as specific fixes for the new home page and plugincheck page.

https://github.com/mozilla/bedrock/commit/40173528fafd76e6736357f87b687720bdae45de
Merge pull request #1372 from craigcook/bug-934703-plugincheck-rtl-layout

Bug 934703 - layout fixes for rtl languages

Comment 5

[raymond [:retornam] (inactive)]

fixed  on https://www.allizom.org/b/fa/plugincheck/ and https://www.allizom.org/he/plugincheck/

Comment 6

[raymond [:retornam] (inactive)]

verified fixed  on https://www.mozilla.org/fa/plugincheck/ and https://www.mozilla.org/he/plugincheck/