Closed
Bug 934883
Opened 11 years ago
Closed 11 years ago
[app manager] Closing a debugged app from the device closes all the toolbox
Categories
(DevTools Graveyard :: WebIDE, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 28
People
(Reporter: paul, Assigned: ochameau)
Details
Attachments
(1 file)
|
3.73 KB,
patch
|
past
:
review+
|
Details | Diff | Splinter Review |
STR: - open a toolbox for "settings" - open a toolbox for "gallery" - on the device, close "settings" Result: - the 2 toolboxes are closed
|
Assignee | |
Comment 1•11 years ago
|
||
|
|
Assignee | |
Comment 2•11 years ago
|
||
Comment on attachment 828124 [details] [diff] [review] Prevent closing all targets when receiving one tabDetached event The issue was that we now instanciate multiple TabTarget per connection and target.js code wasn't filtering tabDetached event to ensure that it was dispatched on the expected TabActor.
Attachment #828124 -
Flags: review?(past)
|
Reporter | |
Comment 3•11 years ago
|
||
Will this need to be uplifted to 1.2?
|
|
Assignee | |
Comment 4•11 years ago
|
||
No, that's a UI/client patch only. Uplift would only for seeing it fixed on firefox 25-27 instead of waiting for 28.
Assignee: nobody → poirot.alex
|
||
Comment 5•11 years ago
|
||
Comment on attachment 828124 [details] [diff] [review] Prevent closing all targets when receiving one tabDetached event Review of attachment 828124 [details] [diff] [review]: ----------------------------------------------------------------- LGTM
Attachment #828124 -
Flags: review?(past) → review+
|
|
Assignee | |
Updated•11 years ago
|
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/3179ecb5f410
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 28
|
||
Updated•6 years ago
|
Product: Firefox → DevTools
|
|
||
Updated•4 years ago
|
Product: DevTools → DevTools Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•