935037 - Remove multi-touch perf opt from MetroInput

Status: RESOLVED FIXED

(Core Graveyard :: Widget: WinRT, defect)

Description

[Jim Mathies [:jimm]]

This is having an adverse effect on apzc responsiveness. Also I don't think this is needed anymore now that we have the HasPointMoved optimization. 

Another issue is that we delay sending touch moves until the first touch point position has changed, which delays the sending of all touch points.

Comment 1

[Jim Mathies [:jimm]]

Attachment: patch

Comment 2

[Tim Abraldes [:TimAbraldes] [:tabraldes]]

Comment on attachment 827438 [details] [diff] [review]
patch

Review of attachment 827438 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me!

::: widget/windows/winrt/MetroInput.cpp
@@ +572,5 @@
>    touch->mChanged = true;
>    // replacing old touch point in mTouches map
>    mTouches.Put(pointerId, touch);
>  
> +  AddPointerMoveDataToRecognizer(aArgs);

Seems like you could move this above line 565, and remove line 567

Comment 3

[Jim Mathies [:jimm]]

updated per comments. 

https://hg.mozilla.org/integration/fx-team/rev/b0c2bafe0fec

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/b0c2bafe0fec