935556 - Add-on SDK uplift broke jetpack tests on Australis | TEST-UNEXPECTED-FAIL | tests/test-ui-button.test button added | icon is set - 'blah/addon-sdk/data/icon.png' == 'blah-at-jetpack.commonjs.path.tests/fixtures/icon.png'

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect)

Description

[:Gijs (he/him)]

https://tbpl.mozilla.org/?tree=UX&rev=c1644bd6aacc

Orange across all platforms and opt/debug/asan, and I'll bet money PGO is busted too, because:

e.g. https://tbpl.mozilla.org/php/getParsedLog.php?id=30206908&tree=UX

TEST-UNEXPECTED-FAIL | tests/test-ui-button.test button added | icon is set - "resource://53ba0f81-583d-4dc5-a9c8-ce891ce22ab1-at-jetpack/addon-sdk/data/icon.png" == "resource://extensions.modules.53ba0f81-583d-4dc5-a9c8-ce891ce22ab1-at-jetpack.commonjs.path.tests/fixtures/icon.png"
TEST-UNEXPECTED-FAIL | tests/test-ui-button.test button global state updated | node image is updated - "resource://extensions.modules.53ba0f81-583d-4dc5-a9c8-ce891ce22ab1-at-jetpack.commonjs.path.tests/fixtures/new-icon.png" == "resource://53ba0f81-583d-4dc5-a9c8-ce891ce22ab1-at-jetpack/addon-sdk/data/new-icon.png"
TEST-UNEXPECTED-FAIL | tests/test-ui-button.test button global state updated on multiple windows | node image is updated - "resource://extensions.modules.53ba0f81-583d-4dc5-a9c8-ce891ce22ab1-at-jetpack.commonjs.path.tests/fixtures/new-icon.png" == "resource://53ba0f81-583d-4dc5-a9c8-ce891ce22ab1-at-jetpack/addon-sdk/data/new-icon.png"
TEST-UNEXPECTED-FAIL | tests/test-ui-button.test button global state updated on multiple windows | node image is updated - "resource://extensions.modules.53ba0f81-583d-4dc5-a9c8-ce891ce22ab1-at-jetpack.commonjs.path.tests/fixtures/new-icon.png" == "resource://53ba0f81-583d-4dc5-a9c8-ce891ce22ab1-at-jetpack/addon-sdk/data/new-icon.png"
TEST-UNEXPECTED-FAIL | tests/test-ui-button.test button icon se with only one option | the icon is set properly in navbar - "resource://extensions.modules.53ba0f81-583d-4dc5-a9c8-ce891ce22ab1-at-jetpack.commonjs.path.tests/fixtures/icon5.png" == "resource://53ba0f81-583d-4dc5-a9c8-ce891ce22ab1-at-jetpack/addon-sdk/data/icon5.png"
TEST-UNEXPECTED-FAIL | tests/test-ui-button.test button icon se with only one option | the icon is set properly in panel - "resource://extensions.modules.53ba0f81-583d-4dc5-a9c8-ce891ce22ab1-at-jetpack.commonjs.path.tests/fixtures/icon5.png" == "resource://53ba0f81-583d-4dc5-a9c8-ce891ce22ab1-at-jetpack/addon-sdk/data/icon5.png"
TEST-UNEXPECTED-FAIL | tests/test-ui-button.test button icon set | the icon is set properly in navbar - "resource://extensions.modules.53ba0f81-583d-4dc5-a9c8-ce891ce22ab1-at-jetpack.commonjs.path.tests/fixtures/icon16.png" == "resource://53ba0f81-583d-4dc5-a9c8-ce891ce22ab1-at-jetpack/addon-sdk/data/icon16.png"
TEST-UNEXPECTED-FAIL | tests/test-ui-button.test button icon set | the icon is set properly in panel - "resource://extensions.modules.53ba0f81-583d-4dc5-a9c8-ce891ce22ab1-at-jetpack.commonjs.path.tests/fixtures/icon32.png" == "resource://53ba0f81-583d-4dc5-a9c8-ce891ce22ab1-at-jetpack/addon-sdk/data/icon32.png"
TEST-UNEXPECTED-FAIL | tests/test-ui-button.test button tab state | node image is correct - "resource://extensions.modules.53ba0f81-583d-4dc5-a9c8-ce891ce22ab1-at-jetpack.commonjs.path.tests/fixtures/good-icon.png" == "resource://53ba0f81-583d-4dc5-a9c8-ce891ce22ab1-at-jetpack/addon-sdk/data/good-icon.png"
TEST-UNEXPECTED-FAIL | tests/test-ui-button.test button tab state | node image is correct - "resource://extensions.modules.53ba0f81-583d-4dc5-a9c8-ce891ce22ab1-at-jetpack.commonjs.path.tests/fixtures/tab-icon.png" == "resource://53ba0f81-583d-4dc5-a9c8-ce891ce22ab1-at-jetpack/addon-sdk/data/tab-icon.png"
TEST-UNEXPECTED-FAIL | tests/test-ui-button.test button window state | node image is correct - "resource://extensions.modules.53ba0f81-583d-4dc5-a9c8-ce891ce22ab1-at-jetpack.commonjs.path.tests/fixtures/icon.png" == "resource://53ba0f81-583d-4dc5-a9c8-ce891ce22ab1-at-jetpack/addon-sdk/data/icon.png"
TEST-UNEXPECTED-FAIL | tests/test-ui-button.test button window state | node image is correct - "resource://extensions.modules.53ba0f81-583d-4dc5-a9c8-ce891ce22ab1-at-jetpack.commonjs.path.tests/fixtures/icon.png" == "resource://53ba0f81-583d-4dc5-a9c8-ce891ce22ab1-at-jetpack/addon-sdk/data/icon.png"

Comment 1

[:Gijs (he/him)]

Which is pretty obvious if you look at:

https://hg.mozilla.org/projects/ux/diff/f4fdb40f96b1/addon-sdk/source/test/test-ui-button.js

Comment 2

[Matteo Ferretti [:zer0] [:matteo]]

Irakli, this is happens because the new `./fixtures` module you introduced, that returns a different value from `data` in `sdk/self` module, so all the assertion about url are failing. I'm not sure I'm following the logic of this change, could you explain a bit? Why you replaced `sdk/data` with `./fixtures`? Can't we have `sdk/data` in those tests too?

Comment 3

[:Gijs (he/him)]

(this was done as part of https://github.com/mozilla/addon-sdk/commit/3aa96e4e333b655c01203553910b4c6820b5f90c which apparently was part of bug 892193)

Comment 4

[:Gijs (he/him)]

Attachment: PR

Comment 5

[Irakli Gozalishvili [:irakli] [:gozala] [@gozala]]

Comment on attachment 828106 [details] [review]
PR

No this is not going to work, there is no data folder left.

Comment 6

[Irakli Gozalishvili [:irakli] [:gozala] [@gozala]]

Comment on attachment 828106 [details] [review]
PR

It looks like, we don't actually care about the file presence so this will work.

Comment 7

[[github robot]]

Commit pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/e0ee67e288dc99a0daf3a9681939f915ba3da4fb
Merge pull request #1280 from gijsk/patch-1

Bug 935556 - Fix regression in ui-button tests r=@gozala

Comment 8

[:Gijs (he/him)]

Irakli, I don't know if you normally close issues when the pull request is in github or wait for it to hit m-c, so I'm leaving this open and the needinfo for that purpose. :-)

https://hg.mozilla.org/projects/ux/rev/7028c2b1e7da

Comment 9

[Dave Townsend [:mossop]]

We mark them as fixed

Comment 25

[:Gijs (he/him)]

https://hg.mozilla.org/mozilla-central/rev/7028c2b1e7da

Comment 26

[Irakli Gozalishvili [:irakli] [:gozala] [@gozala]]

No longer needs info from me.