935848 - '[JavaScript Error: "aMsgHdr is null" {file: "chrome://messenger/content/mailWindowOverlay.js" line: 2834}]' when calling method: [nsIMsgHeaderSink::onEndMsgHeaders]" nsresult: "0x80570021 (NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS

Status: NEW

(Thunderbird :: Mail Window Front End, defect)

Description

[ISHIKAWA, Chiaki]

I see six occurences of the following errors during the run of |make mozmill| test suite
using debug build of comm-central TB.
(This haappened after my refreshing the comm-central tree yesterday, and I had not seen this error before.
I presume this was introduce din the last couple of weeks.)

      6 [Exception... "'[JavaScript Error: "aMsgHdr is null" {file: "chrome://messenger/content/mailWindowOverlay.js" line: 2834}]' when calling method: [nsIMsgHeaderSink::onEndMsgHeaders]"  nsresult: "0x80570021 (NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS)"  location: "native frame :: <unknown filename> :: <TOP_LEVEL> :: line 0"  data: yes]

Interestingly, I find that the error is preceded either by

 - ##!!! ASSERTION: Overwriting an existing document channel!: '(loadFlags & nsIChannel::LOAD_REPLACE) || !(mDocumentRequest.get())', file /new-hd1/extra/ishikawa/TB-3HG/NEW-COMMSRC/mozilla/uriloader/base/nsDocLoader.cpp, line 471
     ... two times

 - WARNING: Subdocument container has no frame: file /new-hd1/extra/ishikawa/TB-3HG/NEW-COMMSRC/mozilla/layout/base/nsDocumentViewer.cpp, line 2360
     ... two times
	   (in one case, this is immediately followed by the assertion line above.)

 - or both in this order (Assertion, no frame, that is)
     ... two times

It looks the assertion and no frame warnings are closely related to this javascript Exception.

mailWindowOverlay.js 2834 line where aMsgHdr is accessed is the line marked with "-->" below.


  setJunkMsg: function(aMsgHdr)
  {
    goUpdateCommand("button_junk");

    let brandName = this.brandBundle.getString("brandShortName");
    let junkBarMsg = this.stringBundle.getFormattedString("junkBarMessage",
                                                          [brandName]);

--> let junkScore = aMsgHdr.getStringProperty("junkscore");
    if (!((junkScore != "") &&
          (junkScore != Components.interfaces.nsIJunkMailPlugin.IS_HAM_SCORE))) {
      // not junk -> just close the notificaion then, if one was showing
      let item = this.msgNotificationBar.getNotificationWithValue("junkContent");
      if (item)
        this.msgNotificationBar.removeNotification(item, true);
      return;
    }



The error lines and the test that caused the errors from the log
 egrep "(^TEST-|aMsgHdr is null)" log1012-mozmill.txt 

 ...
TEST-START | /new-hd1/extra/ishikawa/TB-3HG/NEW-COMMSRC/mail/test/mozmill/folder-display/test-close-window-on-delete.js | test_close_multiple_windows_tabs_on_delete_from_3pane_window
[Exception... "'[JavaScript Error: "aMsgHdr is null" {file: "chrome://messenger/content/mailWindowOverlay.js" line: 2834}]' when calling method: [nsIMsgHeaderSink::onEndMsgHeaders]"  nsresult: "0x80570021 (NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS)"  location: "native frame :: <unknown filename> :: <TOP_LEVEL> :: line 0"  data: yes]
[Exception... "'[JavaScript Error: "aMsgHdr is null" {file: "chrome://messenger/content/mailWindowOverlay.js" line: 2834}]' when calling method: [nsIMsgHeaderSink::onEndMsgHeaders]"  nsresult: "0x80570021 (NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS)"  location: "native frame :: <unknown filename> :: <TOP_LEVEL> :: line 0"  data: yes]
TEST-PASS | /new-hd1/extra/ishikawa/TB-3HG/NEW-COMMSRC/mail/test/mozmill/folder-display/test-close-window-on-delete.js | test-close-window-on-delete.js::test_close_multiple_windows_tabs_on_delete_from_3pane_window

	  ...

TEST-START | /new-hd1/extra/ishikawa/TB-3HG/NEW-COMMSRC/mail/test/mozmill/folder-display/test-summarization.js | setGetProp:98: nbytes=16
[Exception... "'[JavaScript Error: "aMsgHdr is null" {file: "chrome://messenger/content/mailWindowOverlay.js" line: 2834}]' when calling method: [nsIMsgHeaderSink::onEndMsgHeaders]"  nsresult: "0x80570021 (NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS)"  location: "native frame :: <unknown filename> :: <TOP_LEVEL> :: line 0"  data: yes]
TEST-PASS | /new-hd1/extra/ishikawa/TB-3HG/NEW-COMMSRC/mail/test/mozmill/folder-display/test-summarization.js | test-summarization.js::setupModule

	  ...
TEST-START | /new-hd1/extra/ishikawa/TB-3HG/NEW-COMMSRC/mail/test/mozmill/tabmail/test-tabmail-closing.js | test_opening_thread_in_tabs_closing_behaviour
[Exception... "'[JavaScript Error: "aMsgHdr is null" {file: "chrome://messenger/content/mailWindowOverlay.js" line: 2834}]' when calling method: [nsIMsgHeaderSink::onEndMsgHeaders]"  nsresult: "0x80570021 (NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS)"  location: "native frame :: <unknown filename> :: <TOP_LEVEL> :: line 0"  data: yes]
[Exception... "'[JavaScript Error: "aMsgHdr is null" {file: "chrome://messenger/content/mailWindowOverlay.js" line: 2834}]' when calling method: [nsIMsgHeaderSink::onEndMsgHeaders]"  nsresult: "0x80570021 (NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS)"  location: "native frame :: <unknown filename> :: <TOP_LEVEL> :: line 0"  data: yes]
[Exception... "'[JavaScript Error: "aMsgHdr is null" {file: "chrome://messenger/content/mailWindowOverlay.js" line: 2834}]' when calling method: [nsIMsgHeaderSink::onEndMsgHeaders]"  nsresult: "0x80570021 (NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS)"  location: "native frame :: <unknown filename> :: <TOP_LEVEL> :: line 0"  data: yes]
TEST-PASS | /new-hd1/extra/ishikawa/TB-3HG/NEW-COMMSRC/mail/test/mozmill/tabmail/test-tabmail-closing.js | test-tabmail-closing.js::test_opening_thread_in_tabs_closing_behaviour

TIA