936104 - [Gamepad] Pages using only navigator.getGamepads without event listeners don't get gamepad data

Status: VERIFIED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[(not currently active) Ted Mielczarek]

This is silly, but apparently the machinery to scan for gamepads and update the DOM only triggers if you add event listeners for gamepadconnected or gamepaddisconnected. Calling navigator.getGamepads isn't sufficient, which means that pages doing strictly polling won't actually get any gamepad data.

The simple workaround is just to add
addEventListener("gamepadconnected", function() {});

which will make things spin up.

Comment 1

[(not currently active) Ted Mielczarek]

Attachment: pages using only navigator.getGamepads should trigger gamepad backend startup

This fixes this issue for me on a simple local test page. Unfortunately I can't write a test for this because all of the Mochitests use a fake gamepad service, which means they don't need to spin up a platform gamepad service anyway. Conveniently the patch is trivial.

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8342342 [details] [diff] [review]
pages using only navigator.getGamepads should trigger gamepad backend startup

A bit hackish, but mostly because SetHasGamepadEventListener name is odd.
We should change that to WantsGamepadUpdates() or some such, and
then have another method for the 'false' case, perhaps
DisconnectedFromGamepadService()

But you can do that in a followup.

Comment 3

[(not currently active) Ted Mielczarek]

https://hg.mozilla.org/integration/mozilla-inbound/rev/20a6f6176960

Comment 4

[(not currently active) Ted Mielczarek]

Filed bug 947172 on renaming that method.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/20a6f6176960

Comment 6

[(not currently active) Ted Mielczarek]

Attachment: testcase

Here's a testcase you can use for verification. Connecting a gamepad and pressing a button on this page should display a message in the page body.

Comment 7

[Ada [:adalucinet]]

Mozilla/5.0 (Windows NT 6.1; WOW64; rv:28.0) Gecko/20100101 Firefox/28.0

With Nightly from 2013-11-06 no message is displayed.
On latest Aurora (Build ID:20140203004003) a message is displayed in the page body of the attached testcase when a button is pressed on the gamepad. Tested with Xbox 360 and Logitech F310 controllers.