93617 - Print dialog does not stay on top

Status: VERIFIED FIXED

(Core :: Printing: Output, defect)

Description

[(Don't use, old account) - Kai Engert]

When I chose print in Linux, the print dialog comes up. This dialog is modal as
expected. However, when you accidentially click into the parent window (the
browser window), the print dialog is moved behind the browser window, it's now
hidden, and the normal user will be confused, as the application seems to no
longer responsive.

Expected behaviour: Dialog stays always on top of browser window.

See bug 90997.

Comment 1

[(Don't use, old account) - Kai Engert]

Attachment: Suggested fix

Comment 2

[(Don't use, old account) - Kai Engert]

Adding patch, review keywords.

Requesting review.

Comment 3

[dcone (gone)]

Do you just need a review, or do you want this checked in also.

Comment 4

[(Don't use, old account) - Kai Engert]

Would be great if you could check it in for me, as I don't have yet permissions.
Thanks.

Comment 5

[dcone (gone)]

r=dcone

Comment 6

[(Don't use, old account) - Kai Engert]

Thanks for r=. I'm meanwhile able to check in myself, so I can do it, once we
have sr=.

Comment 7

[rods (gone)]

Looks ok, but I really don't know this code...

Comment 8

[Marc Attinasi]

Looks fine to me, but can't we factor that code that is repeated for every
platform into a generic helper method? It looks to be platform neutral. Maybe a
helper routine called GetDialogParent or something. Also, what has been done to
test this?

Comment 9

[dcone (gone)]

Windows and Mac the Dialog stays on top already.. so this is not an issue there.

Comment 10

[(Don't use, old account) - Kai Engert]

To test it, go to a Linux machine, open a web page select print, the print
dialog comes up, now click in the browser contents. If the print dialogs hides,
you see the bug. If the print dialog stays on top of the browser window, it is
fixed.

I see already more code duplication in these four files, for example the
function GetPageDimensions. I suggest to make the wish for reducing code
duplication a separate bug, to speed up landing of this fix. But feel free to
attach a modified patch! However, I already asked for superreview, and this work
will be useless when we attach a new patch. So personally I'd prefer a new bug.

Comment 11

[Marc Attinasi]

sr=attinasi under the assumption that the test suggested by Kai has actually
been performed (I do not have time to patch/build/test this change myself, sorry).

Comment 12

[Asa Dotzler [:asa]]

a=asa on behalf of [e-mail]

Comment 13

[(Don't use, old account) - Kai Engert]

Patch checked in

Comment 14

[sujay]

verified in 10/2 linux build.

looks like it works now....I simply print any page and then
give the browser window focus, the print dialog stays on top
like it should.