Closed
Bug 936267
Opened 11 years ago
Closed 11 years ago
[System][Internet Sharing] Fix error on no SIM device
Categories
(Firefox OS Graveyard :: Gaia::System, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: masashi.honma, Assigned: masashi.honma)
Details
Attachments
(1 file)
This message is displayed on no SIM device's adb logcat.
E/GeckoConsole( 77): [JavaScript Error: "IccHelper.iccInfo is null" {file: "app://system.gaiamobile.org/js/internet_sharing.js" line: 105}]
This patch fixes this issue.
|
Assignee | |
Comment 1•11 years ago
|
||
Attachment #828966 -
Flags: review?(top12345tw)
|
|
Assignee | |
Updated•11 years ago
|
Attachment #828966 -
Attachment mime type: text/plain → text/html
|
||
Updated•11 years ago
|
Attachment #828966 -
Flags: review?(top12345tw) → review?(echen)
|
|
||
Comment 2•11 years ago
|
||
Comment on attachment 828966 [details]
Pull Request
When sim card is not detected, the iccInfo will be |null|. Give r+ for this simple patch, but I still would like to invite Gaia guys to review this.
Thanks for your patch.
Attachment #828966 -
Flags: review?(echen)
Attachment #828966 -
Flags: review?(alive)
Attachment #828966 -
Flags: review+
|
||
Updated•11 years ago
|
Attachment #828966 -
Flags: review?(alive) → review+
|
|
Assignee | |
Comment 3•11 years ago
|
||
echen, Thanks for your review. I made the code shorter.
|
|
Assignee | |
Updated•11 years ago
|
Attachment #828966 -
Flags: review+ → review?(echen)
|
|
||
Comment 4•11 years ago
|
||
Comment on attachment 828966 [details]
Pull Request
Thank you!
Attachment #828966 -
Flags: review?(echen) → review+
|
|
Assignee | |
Updated•11 years ago
|
Keywords: checkin-needed
|
||
Comment 5•11 years ago
|
||
Master: https://github.com/mozilla-b2g/gaia/commit/da7d5a419b7ec62df88bb5a43ade0402fd2011b4
Assignee: nobody → masashi.honma
Status: UNCONFIRMED → RESOLVED
Closed: 11 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•