936322 - Support new key names "GroupNext", "GroupPrevious", "GroupFirst" and "GroupLast" for keyboard layout switching key

Status: RESOLVED FIXED

(Core :: DOM: Events, defect)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

For keyboard layout switching keys, new key names "GroupNext", "GroupPrevious", "GroupFirst" and "GroupLast" are defined.

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Support "GroupFirst", "GroupLast", "GroupNext" and "GroupPrevious" key values on GTK, Android and Gonk

These key are defined for GTK's ISO keys.

According to the definition of ISO,

http://en.wikipedia.org/wiki/ISO/IEC_9995#Groups

this works as switch of keyboard layouts. Therefore, I believe that AKEYCODE_LANGUAGE_SWITCH of Android should be "GroupNext".

https://dvcs.w3.org/hg/dom3events/raw-file/tip/html/DOM3Events-key.html#key-GroupFirst

http://developer.android.com/reference/android/view/KeyEvent.html#KEYCODE_LANGUAGE_SWITCH
>  public static final int KEYCODE_LANGUAGE_SWITCH
> Added in API level 14
> 
> Key code constant: Language Switch key. Toggles the current input language
> such as switching between English and Japanese on a QWERTY keyboard. On some
> devices, the same function may be performed by pressing Shift+Spacebar.

Comment 2

[Karl Tomlinson (:karlt)]

Comment on attachment 8445211 [details] [diff] [review]
Support "GroupFirst", "GroupLast", "GroupNext" and "GroupPrevious" key values on GTK, Android and Gonk

The _Group_Lock variants are not used in any xkeyboard-config layouts, even on layouts where the _Group keys lock the group.

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8445211 [details] [diff] [review]
Support "GroupFirst", "GroupLast", "GroupNext" and "GroupPrevious" key values on GTK, Android and Gonk

So if _Lock aren't actually used, perhaps no need to add them here.

Comment 4

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Support "GroupFirst", "GroupLast", "GroupNext" and "GroupPrevious" key values on GTK, Android and Gonk (r=nchen+karlt+mwu+smaug)

Okay, I removed GDK_*_Lock from the mapping table.

Comment 5

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3f542e61e7fa

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/3f542e61e7fa