936975 - [B2G][Helix][camera][dingyu]The video icon(which show video recording work in background) is will not disappear after a crash in video recording

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::System, defect, P2)

Description

[lecky]

User Agent: Mozilla/5.0 (Windows NT 6.1) AppleWebKit/535.1 (KHTML, like Gecko) Chrome/13.0.782.112 Safari/535.1

Steps to reproduce:

1. open a camera and toggle to the video mode
2. press the capture button and then press the home button many times quickly 


Actual results:

1. a dialog box show "camera just crash" and the video icon is always show and will not disappear after 5s


Expected results:

1. the video icon(which show video recording work in background) should disappear after 5s.

Analyze the code shell.js
---------------------------------------------------------------------
(function recordingStatusTracker() {
  let gRecordingActiveCount = 0;

  Services.obs.addObserver(function(aSubject, aTopic, aData) {
    let oldCount = gRecordingActiveCount;
    if (aData == "starting") {
      gRecordingActiveCount += 1;
    } else if (aData == "shutdown") {
      gRecordingActiveCount -= 1;
    }
    
    // We need to track changes from 1 <-> 0
    if (gRecordingActiveCount + oldCount == 1) {
      shell.sendChromeEvent({
        type: 'recording-status',
        active: (gRecordingActiveCount == 1)
      });
    }
}, "recording-device-events", false);
})();
-----------------------------------------------------------------
when startRecording happens, gRecordingActiveCount will add one, and if the stopRecording happens, gRecordingActiveCount  will delete one. so if a crash happen, there is only startRecording event but have no stopRecording event, the video icon will always exist. and If i startRecording again, the gRecordingActiveCount will become 2 and can not be recovery. 

So if the camera work fine, there is no problem, but if there is a abnormal in camera, the video can not recover to normal unless rebooting the phone. so I think the following code is more  reasonable than original code.
---------------------------------------------
if (aData == "starting") {
      gRecordingActiveCount = 1;
    } else if (aData == "shutdown") {
      gRecordingActiveCount = 1;
    }
----------------------------------------------
But the above code still have a bug, if the crash happen, we need to restart a video recording to recover the video icon status

Comment 1

[Wayne Chang [:wchang]]

Not blocking, but should be investigated and fixed in a future release.

Comment 3

[lecky]

Jason, the bug is not a duplicate of bug 898917. we have merge the change bug 898917 in our code. Please look carefully at the Comment 0 Description.

Comment 4

[Jason Smith [:jsmith]]

(In reply to lecky from comment #3)
> Jason, the bug is not a duplicate of bug 898917. we have merge the change
> bug 898917 in our code. Please look carefully at the Comment 0 Description.

No actually it is. The patch fixes the issue to ensure that we only show the video recording icon for 5 seconds after the content process is killed. The crash indicated here is irrelevant to the bug filed here - the issue is being talked about the persistent notification.

Comment 5

[Jason Smith [:jsmith]]

Oh wait, now I understand. This is a persistent notification on a crash from using the camera recording.

Comment 6

[BMO Automation]

Firefox OS is not being worked on