Closed Bug 937048 Opened 11 years ago Closed 11 years ago

[Flatfish] Marketplace only launch in portrait mode

Categories

(Marketplace Graveyard :: Consumer Pages, defect)

Product:
Marketplace Graveyard
Component:
Consumer Pages
Version:
Avenir
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED WONTFIX
Milestone:
2013-12-03

People

(Reporter: sulapy, Assigned: cvan)

Details

Attachments

(1 file)

Marketplace landscape in browser.jpg
155.50 KB, image/jpeg
Details 
User Agent: Mozilla/5.0 (Windows NT 6.2; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/30.0.1599.101 Safari/537.36

Steps to reproduce:

1. Launch Marketplace on Flatfish
2. Check the screen


Actual results:

Marketplace only shows in portrait mode


Expected results:

Expect Marketplace to support both of landscape and portrait mode based on user's current orientation
Blocks: flatfish
Summary: Marketplace landscape → [Flatfish] Marketplace only launch in portrait mode
Whiteboard: Flatfish
From UX perspective of view. Marketplace should be able to rotate screen as other apps and etc.
Technically this isn't flatfish specific - marketplace locks portrait-primary intentionally, as it hasn't added support for landscape. However - we probably going to need this done for tablet support, given the difference of the default orientation of the tablet being landscape.
Component: General → Consumer Pages
Product: Firefox OS → Marketplace
Version: unspecified → Avenir
This is intentional. See https://bugzilla.mozilla.org/show_bug.cgi?id=844186#c8
Status: UNCONFIRMED → RESOLVED
Closed: 11 years ago
Resolution: --- → WONTFIX
(In reply to Matt Basta [:basta] from comment #3)
> This is intentional. See
> https://bugzilla.mozilla.org/show_bug.cgi?id=844186#c8

And it needs to change - flatfish requires this change. Mike's right - this needs to be supported now for flatfish.
Status: RESOLVED → REOPENED
Ever confirmed: true
Resolution: WONTFIX → ---
We need landscape designs, then. This is not as simple as turning off the orientation flag.
Assignee: nobody → asantos
Keywords: uiwanted
I want someone in the Product Management team to decide what we have to stop working on to pick this up this quarter. We're at capacity for P1s. David, can you prioritize this bug?
Flags: needinfo?(dbialer)
Keywords: productwanted
(In reply to Tony Santos [:tsmuse] from comment #6)
> I want someone in the Product Management team to decide what we have to stop
> working on to pick this up this quarter. We're at capacity for P1s. David,
> can you prioritize this bug?

This really needs to be discussed at the b2g drivers meeting. I want to make sure Francis & Steven are on the same page with the marketplace team in terms of when this needs to be done, as we have committed partner deadlines with flatfish.
(In reply to Jason Smith [:jsmith] from comment #7)
> (In reply to Tony Santos [:tsmuse] from comment #6)
> > I want someone in the Product Management team to decide what we have to stop
> > working on to pick this up this quarter. We're at capacity for P1s. David,
> > can you prioritize this bug?
> 
> This really needs to be discussed at the b2g drivers meeting. I want to make
> sure Francis & Steven are on the same page with the marketplace team in
> terms of when this needs to be done, as we have committed partner deadlines
> with flatfish.

That's fine. I have a team of 3 designers right now for Marketplace and we've committed to a full slate of projects for this quarter. Since this is the first I've heard about this, I want to keep our product manager involved in this conversation because picking this up now means we have to drop something else we're currently working on.
(In reply to Jason Smith [:jsmith] from comment #7)
> This really needs to be discussed at the b2g drivers meeting. I want to make
> sure Francis & Steven are on the same page with the marketplace team in
> terms of when this needs to be done, as we have committed partner deadlines
> with flatfish.

This is not a P1. Nothing here is broken, it's just not ideal. You can use the Marketplace just fine, you just need to turn the device to portrait orientation.

FWIW, many Google apps were portrait-only well into Android 3. For an OS that still has yet to launch its first tablet form-factor device, I'd say we're in satisfactory shape.
(In reply to Matt Basta [:basta] from comment #9)
> (In reply to Jason Smith [:jsmith] from comment #7)
> > This really needs to be discussed at the b2g drivers meeting. I want to make
> > sure Francis & Steven are on the same page with the marketplace team in
> > terms of when this needs to be done, as we have committed partner deadlines
> > with flatfish.
> 
> This is not a P1. Nothing here is broken, it's just not ideal. You can use
> the Marketplace just fine, you just need to turn the device to portrait
> orientation.
> 
> FWIW, many Google apps were portrait-only well into Android 3. For an OS
> that still has yet to launch its first tablet form-factor device, I'd say
> we're in satisfactory shape.

Agree with Matt.  Not a P1, P2. 

Or what would happen if we took off lock in portrait?  Is it really terrible when in landscape more?
Flags: needinfo?(dbialer)
(In reply to David Bialer [:dbialer] from comment #10)
> (In reply to Matt Basta [:basta] from comment #9)
> > (In reply to Jason Smith [:jsmith] from comment #7)
> > > This really needs to be discussed at the b2g drivers meeting. I want to make
> > > sure Francis & Steven are on the same page with the marketplace team in
> > > terms of when this needs to be done, as we have committed partner deadlines
> > > with flatfish.
> > 
> > This is not a P1. Nothing here is broken, it's just not ideal. You can use
> > the Marketplace just fine, you just need to turn the device to portrait
> > orientation.
> > 
> > FWIW, many Google apps were portrait-only well into Android 3. For an OS
> > that still has yet to launch its first tablet form-factor device, I'd say
> > we're in satisfactory shape.
> 
> Agree with Matt.  Not a P1, P2. 

That's not the right way to think about this. There are partner commitments that can dictate the priority of this. If this is a committed requirement of flatfish, then it's automatic P1. There's no room for negotiation on this.

We need a discussion with the associated partner & the UX lead for flatfish to get an understanding of the need here. I don't want end game surprises from a lack of effective partner requirements analysis.
(In reply to Jason Smith [:jsmith] from comment #11)
> (In reply to David Bialer [:dbialer] from comment #10)
> > (In reply to Matt Basta [:basta] from comment #9)
> > > (In reply to Jason Smith [:jsmith] from comment #7)
> > > > This really needs to be discussed at the b2g drivers meeting. I want to make
> > > > sure Francis & Steven are on the same page with the marketplace team in
> > > > terms of when this needs to be done, as we have committed partner deadlines
> > > > with flatfish.
> > > 
> > > This is not a P1. Nothing here is broken, it's just not ideal. You can use
> > > the Marketplace just fine, you just need to turn the device to portrait
> > > orientation.
> > > 
> > > FWIW, many Google apps were portrait-only well into Android 3. For an OS
> > > that still has yet to launch its first tablet form-factor device, I'd say
> > > we're in satisfactory shape.
> > 
> > Agree with Matt.  Not a P1, P2. 
> 
> That's not the right way to think about this. There are partner commitments
> that can dictate the priority of this. If this is a committed requirement of
> flatfish, then it's automatic P1. There's no room for negotiation on this.
> 
> We need a discussion with the associated partner & the UX lead for flatfish
> to get an understanding of the need here. I don't want end game surprises
> from a lack of effective partner requirements analysis.


Sounds like we need to have a meeting to discuss this then.
Let me take this to FxOS drivers and to the FxOS Wave launch meet to get more info on the priority, launch dates, market opportunity (number devices in market) and breadth of developer release.

Jason - These two meets will cover Steven, Francis - Thomas Ho. Jack Guo and Spinger Wang on the Taipei / China bus dev teams who are signing these contracts.

Anyone else?
Blocks: 909557
(In reply to Caitlin Galimidi from comment #13)
> Let me take this to FxOS drivers and to the FxOS Wave launch meet to get
> more info on the priority, launch dates, market opportunity (number devices
> in market) and breadth of developer release.
> 
> Jason - These two meets will cover Steven, Francis - Thomas Ho. Jack Guo and
> Spinger Wang on the Taipei / China bus dev teams who are signing these
> contracts.
> 
> Anyone else?

That sounds like the right group of people to talk to about this.
Can I just ask, who made a commitment to changing the orientation of the Marketplace and why was nobody on the Marketplace informed about this until today?
Can we keep this in perspective of what needs to happen in Q4 (function over form)?  I think there is more time to work on form - which is why, given all the other priorities and the flatfish schedule, I do not believe this is a P1 (blocker).  It doesn't prevent developers from submitting apps and users from getting apps.  

Please let me know if there are any contractual commitments to have a landscape-mode marketplace in Q4, and if so, then we can figure out where it stands in priorities.
(In reply to David Bialer [:dbialer] from comment #10)
> (In reply to Matt Basta [:basta] from comment #9)
> Agree with Matt.  Not a P1, P2. 
> 
> Or what would happen if we took off lock in portrait?  Is it really terrible
> when in landscape more?

I think this can be a reference for your question.
https://bug937051.bugzilla.mozilla.org/attachment.cgi?id=830110
(In reply to sulapy from comment #17)
> I think this can be a reference for your question.
> https://bug937051.bugzilla.mozilla.org/attachment.cgi?id=830110

This looks fine to me.
> > Or what would happen if we took off lock in portrait?  Is it really terrible
> > when in landscape more?
> 
> I think this can be a reference for your question.
> https://bug937051.bugzilla.mozilla.org/attachment.cgi?id=830110

Oops, what I meant is not lock it in portrait mode.  How bad does it look when allowed to go into landscape?  Is is usable?
Discussed in drivers - not needed for the flatfish developer release, so this isn't needed in Q4 2013. We need to discuss more however if this is needed in Q1 2014 for MWC.
(In reply to Matt Basta [:basta] from comment #15)
> Can I just ask, who made a commitment to changing the orientation of the
> Marketplace and why was nobody on the Marketplace informed about this until
> today?

Badly worded - that's not what I meant. What I was originally implying was that we need to make sure that we understand if there are partner requirements & commitments around this feature request. Francis confirmed in drivers this is not needed for the developer release, so we're okay here. Caitlin is following up with the parties in comment 14 to get a better understanding of the flatfish needs for marketplace.
(In reply to David Bialer [:dbialer] from comment #19)
> > > Or what would happen if we took off lock in portrait?  Is it really terrible
> > > when in landscape more?
> > 
> > I think this can be a reference for your question.
> > https://bug937051.bugzilla.mozilla.org/attachment.cgi?id=830110
> 
> Oops, what I meant is not lock it in portrait mode.  How bad does it look
> when allowed to go into landscape?  Is is usable?
No, it doesn't allow me to go into landscape.
(In reply to sulapy from comment #22)
> > Oops, what I meant is not lock it in portrait mode.  How bad does it look
> > when allowed to go into landscape?  Is is usable?
> No, it doesn't allow me to go into landscape.

Please rotate your device 90 degrees anticlockwise and test whether the Marketplace is usable in that orientation.
(In reply to Matt Basta [:basta] from comment #23)
> (In reply to sulapy from comment #22)
> > > Oops, what I meant is not lock it in portrait mode.  How bad does it look
> > > when allowed to go into landscape?  Is is usable?
> > No, it doesn't allow me to go into landscape.
> 
> Please rotate your device 90 degrees anticlockwise and test whether the
> Marketplace is usable in that orientation.

For clarification - you'll need to test this at https://marketplace.firefox.com to see how this looks in landscape. The marketplace app locks itself to portrait-primary, so you can't see the app in landscape layout.
(In reply to Jason Smith [:jsmith] from comment #24)
> (In reply to Matt Basta [:basta] from comment #23)
> > (In reply to sulapy from comment #22)
> > > > Oops, what I meant is not lock it in portrait mode.  How bad does it look
> > > > when allowed to go into landscape?  Is is usable?
> > > No, it doesn't allow me to go into landscape.
> > 
> > Please rotate your device 90 degrees anticlockwise and test whether the
> > Marketplace is usable in that orientation.

As Jason said, the marketplace app does not allow to show that way.

> 
> For clarification - you'll need to test this at
> https://marketplace.firefox.com to see how this looks in landscape. The
> marketplace app locks itself to portrait-primary, so you can't see the app
> in landscape layout.

My intention is to have Marketplace support for landscape-primary device. [Marketplace app itself and also the apps category in the market.]   Anyway, I attached the landscape marketplace in browser picture for reference. :)

    
    

    
  
(In reply to sulapy from comment #25)
> As Jason said, the marketplace app does not allow to show that way.
> 

Are you saying that if you physically turn your device sideways it rotates the Marketplace *again* preventing it from ever being properly oriented? There's no way at all to view the Marketplace in the proper orientation?

    
    

    
  
From Francis Lee > 
there is no hard requirement from hardware vendor that marketplace will perform / behave a certain way

From Marketplace Leads (product / ux / qa) > 
will want to consider quality of marketplace performance and appearance on device in time for developer release

Current timeline:
https://mana.mozilla.org/wiki/display/PM/Firefox+OS+Wave+Launch+Cross+Functional+View

    
    

    
  
(In reply to Matt Basta [:basta] from comment #27)
> (In reply to sulapy from comment #25)
> > As Jason said, the marketplace app does not allow to show that way.
> > 
> 
> Are you saying that if you physically turn your device sideways it rotates
> the Marketplace *again* preventing it from ever being properly oriented?
> There's no way at all to view the Marketplace in the proper orientation?

Marketplace app launch with fixed orientation.  No matter what orientation or angle I rotated, it kept screen fixed without any change.

    
    

    
  
It rotates fine in a Firefox on an Android nexus 7 tablet with an HDMI display.  It uses a responsive design. 

I assume that the manifest declares to lock it in portrait mode.

I would think that if orientation is removed from the manifest so that it stops locking, it would be fine and good enough for now with the current UI.

    
    

    
  
(In reply to David Bialer [:dbialer] from comment #30)
> I assume that the manifest declares to lock it in portrait mode.

We do. We force `portrait-primary`:

https://github.com/mozilla/fireplace/blob/master/yulelog/manifest.webapp#L33

    
    

    
  
In other gaia build-in app, we've changed our orientation from 'portrait-primary' to 'default' in manifest, which will let device decide the default orientation.

After changed orientation from 'portrait-primary' to 'default' in manifest, the marketplace app on tablet could work in landscape (but may not optimized yet).

    
    

    
  
(In reply to Fred Lin [:gasolin] from comment #32)
> In other gaia build-in app, we've changed our orientation from
> 'portrait-primary' to 'default' in manifest, which will let device decide
> the default orientation.
> 
> After changed orientation from 'portrait-primary' to 'default' in manifest,
> the marketplace app on tablet could work in landscape (but may not optimized
> yet).

I will change orientation in our manifest, but we'll need to address design changes then.
Assignee: asantos → cvan
Target Milestone: --- → 2013-12-03

    
    

    
  
I would advise against this change, as the Marketplace layout was not designed with landscape mode in mind and just letting it do whatever it needs to do to reflow isn't a very good decision. Because the initial roll out of this is a developer preview, I don't see why this change needs to be rushed through. We can definitely work out what Marketplace in landscape mode needs to look like, but we can't do it before the initial push. I think users in a developer preview are not going to be completely flummoxed by having to rotate their device to use the Marketplace.

    
    

    
  
Comment 34 certainly sounds reasonable to me.
Status: REOPENED → RESOLVED
Closed: 11 years ago → 11 years ago
Resolution: --- → WONTFIX

    
    

    
  
> I think users in a developer preview are not going to be completely flummoxed by having to rotate their device to use the Marketplace.

+1

I should also remind everyone (again) that on Android 1.x, the Android Market (what became Google Play) was portrait-only and required the user to rotate their device in the exact same way we do. It wasn't until well into Android 2.x that the Market supported a landscape layout.

http://www.pushing-pixels.org/2010/12/13/meet-the-green-goblin-part-1.html

    
    

    
  
(In reply to Christopher Van Wiemeersch [:cvan] from comment #35)
> Comment 34 certainly sounds reasonable to me.

comment 34 isn't arguing for a WONTFIX. It's arguing for the fact that we don't need to rush changing the manifest field to enable this without any UX forethought. All that means is that we should plan carefully to get landscape support in marketplace before we decide to enable this.
Status: RESOLVED → REOPENED
Resolution: WONTFIX → ---

    
    

    
  
The bug description is "Marketplace only launch in portrait mode." And it sounds like we're fine with it launching only in portrait mode. If the request is for UX to make landscape designs, let's file a new bug for that. 38 comments in and it seems kind of ridiculous to keep this open.

    
    

    
  
(In reply to Christopher Van Wiemeersch [:cvan] from comment #38)
> The bug description is "Marketplace only launch in portrait mode." And it
> sounds like we're fine with it launching only in portrait mode. If the
> request is for UX to make landscape designs, let's file a new bug for that.
> 38 comments in and it seems kind of ridiculous to keep this open.

Okay, fair enough. I've opened bug 944077 to track this.
No longer blocks: flatfish, 909557
Status: REOPENED → RESOLVED
Closed: 11 years ago → 11 years ago
Keywords: productwanted, 
          
            uiwanted
Resolution: --- → WONTFIX
Whiteboard: Flatfish

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: