937263 - Supersearch for multi-word term is confusing

Status: RESOLVED FIXED

(Socorro :: Webapp, task, P1)

Description

[Benjamin Smedberg]

I supersearched:

"app notes" "has terms" "cycle collector fault"

https://crash-stats.mozilla.com/search/?app_notes=cycle+collector+fault&_facets=signature&_columns=date&_columns=signature&_columns=product&_columns=version&_columns=build_id&_columns=platform

This produces no results because ES is tokenizing these on word boundaries. Adrian provided a workaround with:

"app notes" "has terms" "cycle"+"collector"+"fault"

https://crash-stats.mozilla.com/search/?app_notes=cycle&app_notes=collector&app_notes=fault

This is not exactly the search I wanted; I want to be able to search for that phrase, even if internally ES is tokenizing by word and then filtering later. In any case, if the first form isn't going to return any results, the UI shouldn't let you enter it that way.

Comment 1

[Robert Kaiser]

Also, it looks a lot to me like what https://crash-stats.mozilla.com/search/?app_notes=cycle&app_notes=collector&app_notes=fault does is to actually search for "cycle" or "collector" or "fault" (instead of *and*) so it's even more insufficient with what we get atm.

Comment 2

[[DEACTIVATED] Adrian Gaudebert]

Elasticsearch indeed does an "OR" by default when several fields are passed with the same operator. I can change that to be an "AND". http://www.elasticsearch.org/guide/en/elasticsearch/reference/current/query-dsl-terms-filter.html

KaiRo, is that what you want?

Comment 3

[Benjamin Smedberg]

No. The search should in effect be a true substring search. Probably you want ES to search using AND and then filter on the actual data.

Comment 4

[Robert Kaiser]

(In reply to Adrian Gaudebert [:adrian] from comment #2)
> KaiRo, is that what you want?

There's two things: The most pressing is what Benjamin says in comment #3. The other is that I think it would be good if both AND and OR would be available in some form (and it would be obvious to people what is in effect).

Comment 5

[[DEACTIVATED] Adrian Gaudebert]

Pull request: https://github.com/mozilla/socorro/pull/1845

Steps to QA
-----------
1. See first comment! :)

Comment 6

[[github robot]]

Commit pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/0da1064952ab84c234475f8ea7a879783e141b23
Fixes bugs 922739, 937263, 959617 - Added phrase queries to Super Search.