937384 - upgrade metric collective to fix fqdn case

Status: RESOLVED FIXED

(Infrastructure & Operations :: RelOps: General, task)

Description

[Jake Watkins [:dividehex]]

We noticed when deploying metric collective to windows test slaves, that fqdn names used in the metric path were inconsistent.  Some would be all UPPER case and others were all lower case.  This was really a pain then the difference showed up between 2008rev1 and 2008rev2 slaves.  I've patched metric collective to convert fqdn to lower so we should upgrade all the releng windows systems ASAP.  This will cause new db files to be created.  Since graphte6 handled the new DB creates during the first deploy, I don't think we need to pace the upgrades this time around.

Upgrading this should be straight forward.
* stop metcollect service
* update metcollect.py
* start metcollect service

After that we can go back and delete all the stale db files.

Q, Mark: I'll need your input on how to properly proceed on upgrading.

Comment 1

[Mark Cornmesser [:markco] OOO 2024/04/15]

I think we can just edit the existing GPO. 

First we will need to replace the source file metcollect.py and change the file copy in the gpo to replace instead of create. 

Then we can either wait on the next reboot for the service to stop and start, or we can come up with an immediate task some type of item level targeting to trigger the service stop and start. 

Q, do you have a suggestion on another way to approach this?

Comment 2

[Jake Watkins [:dividehex]]

Per IRC, Mark will be updating the metcollect.py on all releng windows hosts today.  This will cause creates on graphite6 for any hosts that was previously reporting in with a hostname in UPPER case.

Comment 3

[Q]

Do we need to worry about this on rev1 builders ?

Comment 4

[Jake Watkins [:dividehex]]

(In reply to Q from comment #3)
> Do we need to worry about this on rev1 builders ?

Yes.  This needs to be applied to all releng windows systems currently deployed with Metrics Collective

Comment 5

[Amy Rich [:arr] [:arich]]

There are no more rev1 builders as of bug 975131.