Closed
Bug 937584
Opened 11 years ago
Closed 11 years ago
Modify test_sms_to_dialer.py to use SendSMS atom
Categories
(Firefox OS Graveyard :: Gaia::UI Tests, defect, P4)
Tracking
(b2g-v1.2 affected)
RESOLVED
FIXED
| Tracking | Status | |
|---|---|---|
| b2g-v1.2 | --- | affected |
People
(Reporter: zcampbell, Assigned: viorela)
References
Details
Attachments
(2 files, 2 obsolete files)
Instead of using the ui to send the message, change the test to use the sendSMS atom. So test case will be: 1. Send SMS to phone using atom 2. Wait for SMS 3. Load Messages app 4. Open messages thread 5. Tap header/Resume remainder of test case
|
Assignee | |
Updated•11 years ago
|
Assignee: nobody → viorela.ioia
|
|
Assignee | |
Comment 1•11 years ago
|
||
pointer to github PR: https://github.com/mozilla-b2g/gaia/pull/13743
Attachment #832926 -
Flags: review?(zcampbell)
Attachment #832926 -
Flags: review?(trifandreialin)
Attachment #832926 -
Flags: review?(moz.teodosia)
Attachment #832926 -
Flags: review?(florin.strugariu)
Attachment #832926 -
Flags: review?(andrei.hutusoru)
|
||
Updated•11 years ago
|
Attachment #832926 -
Flags: review?(florin.strugariu) → review+
|
||
Updated•11 years ago
|
Attachment #832926 -
Flags: review?(trifandreialin) → review+
|
Reporter | |
Updated•11 years ago
|
Attachment #832926 -
Flags: review?(zcampbell)
Attachment #832926 -
Flags: review?(moz.teodosia)
Attachment #832926 -
Flags: review?(andrei.hutusoru)
Attachment #832926 -
Flags: review-
|
|
Reporter | |
Comment 2•11 years ago
|
||
Revised test case: 1. Send SMS to phone using atom 2. Load Messages app 3. Wait for SMS 4. Open messages thread 5. Tap header/Resume remainder of test case
|
|
Assignee | |
Comment 3•11 years ago
|
||
pointer to Github PR
Attachment #8335239 -
Flags: review?(zcampbell)
Attachment #8335239 -
Flags: review?(trifandreialin)
Attachment #8335239 -
Flags: review?(florin.strugariu)
Attachment #8335239 -
Flags: review?(andrei.hutusoru)
|
|
||
Comment 4•11 years ago
|
||
Comment on attachment 8335239 [details] [review] updated PR acccording to test case changes LGTM except for the nit
Attachment #8335239 -
Flags: review?(florin.strugariu) → review-
|
|
Assignee | |
Comment 5•11 years ago
|
||
pointer to Github PR: https://github.com/mozilla-b2g/gaia/pull/13743
Attachment #832926 -
Attachment is obsolete: true
Attachment #8335239 -
Attachment is obsolete: true
Attachment #8335239 -
Flags: review?(zcampbell)
Attachment #8335239 -
Flags: review?(trifandreialin)
Attachment #8335239 -
Flags: review?(andrei.hutusoru)
Attachment #8335325 -
Flags: review?(zcampbell)
Attachment #8335325 -
Flags: review?(trifandreialin)
Attachment #8335325 -
Flags: review?(florin.strugariu)
|
|
||
Updated•11 years ago
|
Attachment #8335325 -
Flags: review?(florin.strugariu) → review+
|
||
Updated•11 years ago
|
Attachment #8335325 -
Flags: review+
|
|
Reporter | |
Comment 6•11 years ago
|
||
Comment on attachment 8335325 [details] [review] updated PR r- see PR comments.
Attachment #8335325 -
Flags: review?(zcampbell) → review-
|
|
Assignee | |
Updated•11 years ago
|
Attachment #8335325 -
Flags: review- → review?
|
|
Reporter | |
Comment 7•11 years ago
|
||
Merged master: https://github.com/mozilla-b2g/gaia/commit/44ce90d92f309898f914bd35a61b17cbc8fc3088
|
|
Reporter | |
Comment 8•11 years ago
|
||
Comment on attachment 8335325 [details] [review] updated PR r+
Attachment #8335325 -
Flags: review?(trifandreialin)
Attachment #8335325 -
Flags: review?
Attachment #8335325 -
Flags: review+
|
||
Comment 9•11 years ago
|
||
Is there a reason this should not be uplifted to v1.2? I think not, so I am setting the flag.
status-b2g-v1.2:
--- → affected
|
||
Comment 10•11 years ago
|
||
Pointer to Github pull-request
|
|
||
Comment 11•11 years ago
|
||
Comment on attachment 8339118 [details] Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/14106 v1.2
Attachment #8339118 -
Flags: review?(trifandreialin)
Attachment #8339118 -
Flags: review?(florin.strugariu)
Attachment #8339118 -
Flags: review?(bob.silverberg)
|
|
||
Comment 12•11 years ago
|
||
Comment on attachment 8339118 [details] Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/14106 I am seeing intermittent failures. See the PR for details.
Attachment #8339118 -
Flags: review?(bob.silverberg) → review-
|
|
||
Updated•11 years ago
|
Attachment #8339118 -
Flags: review?(florin.strugariu) → review-
|
|
||
Comment 13•11 years ago
|
||
Comment on attachment 8339118 [details] Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/14106 Comment in the pr
Attachment #8339118 -
Flags: review?(trifandreialin) → review+
|
|
||
Comment 14•11 years ago
|
||
Comment on attachment 8339118 [details] Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/14106 r+, but with one change. Please see my comments in the PR for a solution to the intermittents I was seeing.
Attachment #8339118 -
Flags: review- → review+
|
|
||
Comment 15•11 years ago
|
||
Comment on attachment 8339118 [details] Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/14106 Updated according reviews!
Attachment #8339118 -
Flags: review+ → review?(bob.silverberg)
|
|
||
Comment 16•11 years ago
|
||
Comment on attachment 8339118 [details] Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/14106 my r+ still stands The pull was updated
Attachment #8339118 -
Flags: review- → review?(florin.strugariu)
|
|
||
Comment 17•11 years ago
|
||
Comment on attachment 8339118 [details] Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/14106 Good to merge when the tree reopens.
Attachment #8339118 -
Flags: review?(bob.silverberg) → review+
|
|
||
Updated•11 years ago
|
Attachment #8339118 -
Flags: review?(florin.strugariu) → review+
|
|
||
Comment 18•11 years ago
|
||
Merged: Master: https://github.com/mozilla-b2g/gaia/commit/44ce90d92f309898f914bd35a61b17cbc8fc3088 V1.2 https://github.com/mozilla-b2g/gaia/commit/db08545c99e864c606b3cfba213d1f4b5670144f
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•