937803 - MockedOpen should optionally not intercept all writes

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Gregory Szorc [:gps]]

I need to extend MockedOpen to not intercept all writes in order to test WebIDL foo in bug 928195.

Comment 1

[Gregory Szorc [:gps]]

Attachment: MockedOpen should optionally not intercept all writes

Simple change with basic tests.

Comment 2

[Mike Hommey [:glandium]]

What is your usecase?

Comment 3

[Gregory Szorc [:gps]]

I have a test that needs to simulate a file in the source directory. While that file's presence is simulated, we write out some other files. There are later tests that trigger code performing os.path.exists(), which currently fails for files written via MockedOpen. I suppose an alternative patch would be to have MockedOpen intercept os.path.exists. But that would need to be behind an optional argument so tests against MockedOpen could be written. Pick your poison.

Comment 4

[Mike Hommey [:glandium]]

(In reply to Gregory Szorc [:gps] from comment #3)
> I suppose an alternative patch would
> be to have MockedOpen intercept os.path.exists. But that would need to be
> behind an optional argument so tests against MockedOpen could be written.
> Pick your poison.

As I've had this problem in the past with os.path.exists and MockedOpen, I'd prefer MockedOpen intercepting os.path.exists.

Comment 5

[Mike Hommey [:glandium]]

Note I don't think you need an optional argument for os.path.exists being intercepted or not. You just need to get os.path.exists value in your test function before MockedOpen intercepts it.

Comment 6

[Gregory Szorc [:gps]]

Attachment: os.path.exists should work with MockedOpen

Changed patch to work with os.path.exists.

Comment 7

[Mike Hommey [:glandium]]

Comment on attachment 8334066 [details] [diff] [review]
os.path.exists should work with MockedOpen

Review of attachment 8334066 [details] [diff] [review]:
-----------------------------------------------------------------

::: config/tests/unit-mozunit.py
@@ +30,5 @@
>  
>              # Check that overwriting these files alters their content.
>              with open('file1', 'w') as file:
>                  file.write('foo')
> +            self.assertTrue(os.path.exists('file1'))

Please add another test before and after file3 is created.

Comment 8

[Gregory Szorc [:gps]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e4e085ffb2dd

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/e4e085ffb2dd