937977 - [traceback] KeyError: 16 - files.forms in <genexpr> - /files/browse/226271/ throws a 500 on dev

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

https://addons-dev.allizom.org/en-US/firefox/files/browse/226271/ is throwing a 500; sorry, but I don't have the traceback handy.

Comment 1

[Stephen Donner [:stephend] Not actively reading bugmail]

[traceback] KeyError: 16 - files.forms in <genexpr>

http://sentry.dmz.phx1.mozilla.com/addons/addons-dev/group/17094/

files.forms in <genexpr>
KeyError: 16

Stacktrace (most recent call last):

  File "django/core/handlers/base.py", line 111, in get_response
    response = callback(request, *callback_args, **callback_kwargs)
  File "newrelic/hooks/framework_django.py", line 485, in wrapper
    return wrapped(*args, **kwargs)
  File "django/views/decorators/csrf.py", line 77, in wrapped_view
    return view_func(*args, **kwargs)
  File "files/decorators.py", line 63, in wrapper
    response = func(request, obj, *args, **kw)
  File "django/views/decorators/http.py", line 147, in inner
    response = func(request, *args, **kwargs)
  File "files/views.py", line 112, in browse
    return jingo.render(request, tmpl, data)
  File "jingo/__init__.py", line 80, in render
    rendered = render_to_string(request, template, context)
  File "jingo/__init__.py", line 98, in render_to_string
    return template.render(**get_context())
  File "newrelic/api/function_trace.py", line 79, in dynamic_wrapper
    return wrapped(*args, **kwargs)
  File "jinja2/environment.py", line 891, in render
    return self.environment.handle_exception(exc_info, True)
  File "/data/addons-dev/www/addons-dev.allizom.org/deploy-zamboni-dev-20131113032144-cd96ead5b5/zamboni/apps/files/templates/files/viewer.html", line 1, in top-level template code
    {% extends "files/base.html" %}
  File "/data/addons-dev/www/addons-dev.allizom.org/deploy-zamboni-dev-20131113032144-cd96ead5b5/zamboni/apps/files/templates/files/base.html", line 1, in top-level template code
    {% extends "base.html" %}
  File "/data/addons-dev/www/addons-dev.allizom.org/deploy-zamboni-dev-20131113032144-cd96ead5b5/zamboni/templates/base.html", line 117, in top-level template code
    {% block main_content %}
  File "/data/addons-dev/www/addons-dev.allizom.org/deploy-zamboni-dev-20131113032144-cd96ead5b5/zamboni/templates/base.html", line 120, in block "main_content"
    {% block content %}{% endblock %}
  File "/data/addons-dev/www/addons-dev.allizom.org/deploy-zamboni-dev-20131113032144-cd96ead5b5/zamboni/apps/files/templates/files/viewer.html", line 23, in block "content"
    {{ form.left }}
  File "nuggets/safe_django_forms.py", line 55, in __html__
    return unicode(self)
  File "django/forms/forms.py", line 411, in __unicode__
    return self.as_widget()
  File "django/forms/forms.py", line 458, in as_widget
    return widget.render(name, self.value(), attrs=attrs)
  File "django/forms/widgets.py", line 547, in render
    options = self.render_options(choices, [value])
  File "files/forms.py", line 66, in render_options
    output.extend(option(distinct_files[0], ver.version))
  File "files/forms.py", line 39, in option
    for f in files)
  File "files/forms.py", line 39, in <genexpr>
    for f in files)

Comment 3

[Christopher Van Wiemeersch [:cvan]]

https://github.com/mozilla/zamboni/commit/0110830

Looks like Kevin fixed this by reverting his patch.

Comment 4

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED on dev; thanks!