Closed Bug 937978 Opened 11 years ago Closed 11 years ago

gfx/2d/DrawTargetCairo.cpp:856:25: error: 'CAIRO_SUBPIXEL_ANTIALIASING_ENABLED' was not declared in this scope

Categories

(Core :: Graphics: Text, defect)

Product:
Core
Component:
Graphics: Text
Platform:
x86
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla28
Tracking Flags:
Tracking Status
firefox27 --- fixed
firefox28 --- fixed

People

(Reporter: b1060552, Assigned: feiko)

References

Details

(Whiteboard: [qa-])

Attachments

(1 file)

nop
1.03 KB, patch
mattwoodrow
: review+
lsblakk
: approval-mozilla-beta+
Details | Diff | Splinter Review 
When trying to build firefox with --enable-system-cairo it fails on

gfx/2d/DrawTargetCairo.cpp:856:25: error:
      use of undeclared identifier 'CAIRO_SUBPIXEL_ANTIALIASING_ENABLED'
    aPermitSubpixelAA ? CAIRO_SUBPIXEL_ANTIALIASING_ENABLED : CAIRO_SUBPIXEL...
                        ^
gfx/2d/DrawTargetCairo.cpp:856:63: error:
      use of undeclared identifier 'CAIRO_SUBPIXEL_ANTIALIASING_DISABLED'
    aPermitSubpixelAA ? CAIRO_SUBPIXEL_ANTIALIASING_ENABLED : CAIRO_SUBPIXEL...
                                                              ^
2 errors generated.

This is similar to bug 623797 in that bug 363861 was never upstreamed.
Blocks: 926023
Attached patch nop — — Splinter Review 

        Attachment #831291 -
        Flags: review?(matt.woodrow)

        Attachment #831291 -
        Flags: review?(matt.woodrow) → review+

    
  
Keywords: checkin-needed

    
  
Assignee: nobody → feiko

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/5d4d2a7ffe3a
Status: UNCONFIRMED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28

    
    

    
  
Comment on attachment 831291 [details] [diff] [review]
nop

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Bug 926023, backported to Firefox 27.
User impact if declined: Failing build with --enable-system-cairo.
Testing completed (on m-c, etc.): m-c, m-a
Risk to taking this patch (and alternatives if risky): Very low
String or IDL/UUID changes made by this patch: None

        Attachment #831291 -
        Flags: approval-mozilla-beta?

        Attachment #831291 -
        Flags: approval-mozilla-beta? → approval-mozilla-beta+

    
  
Whiteboard: [qa-]

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: