Closed
Bug 938208
Opened 11 years ago
Closed 11 years ago
Write test to enable Power Save mode
Categories
(Firefox OS Graveyard :: Gaia::UI Tests, defect, P4)
Tracking
(b2g-v1.2 fixed)
RESOLVED
FIXED
| Tracking | Status | |
|---|---|---|
| b2g-v1.2 | --- | fixed |
People
(Reporter: zcampbell, Assigned: AlinT)
Details
Attachments
(2 files, 1 obsolete file)
This test is very similar to test_settings_airplane_mode.py You will need a device to write this test. setUp: Using the APIs, enable data, bluetooth and geolocation Test case: 1. Navigate to Settings app 2. Enable power save mode 3. Assert that data, bluetooth, geolocation are all disabled
|
||
Comment 1•11 years ago
|
||
Pointer to Github pull-request
|
|
||
Updated•11 years ago
|
Attachment #8335407 -
Flags: review?(zcampbell)
Attachment #8335407 -
Flags: review?(trifandreialin)
Attachment #8335407 -
Flags: review?(florin.strugariu)
Attachment #8335407 -
Flags: review?(bob.silverberg)
|
||
Comment 2•11 years ago
|
||
Comment on attachment 8335407 [details] Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/13880 The test doesn't pass and it isn't checking the correct things. See the PR for details.
Attachment #8335407 -
Flags: review?(bob.silverberg) → review-
|
||
Updated•11 years ago
|
Attachment #8335407 -
Flags: review?(florin.strugariu) → review-
|
|
||
Updated•11 years ago
|
Attachment #8335407 -
Flags: review?
Attachment #8335407 -
Flags: review-
|
|
||
Updated•11 years ago
|
Attachment #8335407 -
Flags: review? → review+
|
Assignee | |
Updated•11 years ago
|
Attachment #8335407 -
Flags: review?(trifandreialin) → review+
|
|
Assignee | |
Comment 3•11 years ago
|
||
Merged in commit: https://github.com/mozilla-b2g/gaia/commit/ec850b4664c1781f790b83ccf8398bf90e7c3482
|
|
Assignee | |
Updated•11 years ago
|
status-b2g-v1.2:
--- → affected
|
|
Assignee | |
Comment 4•11 years ago
|
||
I will uplift it to v1.2, assigning myself
|
|
Assignee | |
Updated•11 years ago
|
Assignee: nobody → trifandreialin
|
Reporter | |
Comment 5•11 years ago
|
||
Reverted this because some nits in the pull weren't addressed: https://github.com/mozilla-b2g/gaia/commit/62d09fb5fb595c63356e493c192d878fa7128cdc
|
|
Assignee | |
Comment 6•11 years ago
|
||
Pointer to Github pull-request
|
|
Assignee | |
Comment 7•11 years ago
|
||
Comment on attachment 8341691 [details] Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/14312 pull request for v1.2
Attachment #8341691 -
Flags: review?(viorela.ioia)
Attachment #8341691 -
Flags: review?(florin.strugariu)
Attachment #8341691 -
Flags: review?(bob.silverberg)
Attachment #8341691 -
Flags: review?(andrei.hutusoru)
|
|
Assignee | |
Comment 8•11 years ago
|
||
Pointer to Github pull-request
|
|
Assignee | |
Comment 9•11 years ago
|
||
Comment on attachment 8341696 [details] Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/14313 New pull for this test, with comment addressed
Attachment #8341696 -
Flags: review?(zcampbell)
Attachment #8341696 -
Flags: review?(viorela.ioia)
Attachment #8341696 -
Flags: review?(florin.strugariu)
Attachment #8341696 -
Flags: review?(bob.silverberg)
Attachment #8341696 -
Flags: review?(andrei.hutusoru)
|
|
Assignee | |
Updated•11 years ago
|
Attachment #8335407 -
Attachment is obsolete: true
Attachment #8335407 -
Flags: review?(zcampbell)
Attachment #8335407 -
Flags: review?
|
|
||
Comment 10•11 years ago
|
||
Comment on attachment 8341696 [details] Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/14313 Just a tiny nit in the PR, so this gets my r+. Just one question though, should we also switch power save off and make sure that everything gets re-enabled?
Attachment #8341696 -
Flags: review?(bob.silverberg) → review+
|
|
||
Updated•11 years ago
|
Flags: needinfo?(zcampbell)
|
|
||
Comment 11•11 years ago
|
||
Comment on attachment 8341691 [details] Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/14312 We really shouldn't be submitting PRs for uplifts before the change lands on master. We should wait until there is a commit on master to cherry-pick.
Attachment #8341691 -
Flags: review?(bob.silverberg) → review-
|
||
Updated•11 years ago
|
Attachment #8341696 -
Flags: review?(viorela.ioia) → review+
|
|
||
Comment 12•11 years ago
|
||
Comment on attachment 8341696 [details] Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/14313 Fix the nit and we are good
Attachment #8341696 -
Flags: review?(florin.strugariu) → review+
|
|
Assignee | |
Comment 13•11 years ago
|
||
Comment on attachment 8341691 [details] Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/14312 nit fixed
Attachment #8341691 -
Flags: review- → review?(bob.silverberg)
|
|
||
Comment 14•11 years ago
|
||
Comment on attachment 8341696 [details] Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/14313 Landed on master in https://github.com/mozilla-b2g/gaia/commit/5ef899d6dbc22db707e998405500f71fb0842fdc
Attachment #8341696 -
Flags: review?(zcampbell)
Attachment #8341696 -
Flags: review?(andrei.hutusoru)
|
|
||
Comment 15•11 years ago
|
||
Comment on attachment 8341691 [details] Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/14312 Landed on v1.2 in https://github.com/mozilla-b2g/gaia/commit/daa07bf53d8aec315fa8b9f07d356a30c77fb593
Attachment #8341691 -
Flags: review?(viorela.ioia)
Attachment #8341691 -
Flags: review?(florin.strugariu)
Attachment #8341691 -
Flags: review?(bob.silverberg)
Attachment #8341691 -
Flags: review?(andrei.hutusoru)
Attachment #8341691 -
Flags: review+
|
|
||
Updated•11 years ago
|
Status: NEW → RESOLVED
Closed: 11 years ago
Flags: needinfo?(zcampbell)
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•