Closed
Bug 939139
Opened 11 years ago
Closed 11 years ago
[Music] Update scrubber to be consistent with the video player
Categories
(Firefox OS Graveyard :: Gaia::Music, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: epang, Assigned: pivanov)
References
Details
(Whiteboard: ux-tracking, visual design, visual-tracking, jian)
Attachments
(2 files)
Pavel, I'm attached designs and specs for the now playing screen in Music. Please let me know if you have any questions. Thanks!
Assignee | ||
Comment 1•11 years ago
|
||
Hey Eric, can you check this on your device? :)
Attachment #833324 -
Flags: feedback?(epang)
Reporter | ||
Comment 3•11 years ago
|
||
(In reply to Pavel Ivanov [:ivanovpavel] from comment #1) > Created attachment 833324 [details] [review] > patch for Gaia/master > > Hey Eric, > can you check this on your device? :) Pavel, I'm reviewing this new. Going to send you some feedback via email soon for some changes. Thanks!
Flags: needinfo?(pivanov)
Reporter | ||
Comment 4•11 years ago
|
||
Comment on attachment 833324 [details] [review] patch for Gaia/master Looks great, ready for review. Thanks!!
Attachment #833324 -
Flags: feedback?(epang) → feedback+
Assignee | ||
Updated•11 years ago
|
Attachment #833324 -
Flags: review?(squibblyflabbetydoo)
Comment 5•11 years ago
|
||
Comment on attachment 833324 [details] [review] patch for Gaia/master I have a couple of minor comments on Github. r=me with those addressed. Thanks!
Attachment #833324 -
Flags: review?(squibblyflabbetydoo) → review+
Reporter | ||
Comment 6•11 years ago
|
||
(In reply to Jim Porter (:squib) from comment #5) > Comment on attachment 833324 [details] [review] > patch for Gaia/master > > I have a couple of minor comments on Github. r=me with those addressed. > Thanks! Thanks Jim! Pavel can you look into Jim's comments? Thanks!
Assignee | ||
Comment 7•11 years ago
|
||
Thanks :) Landed in master: https://github.com/mozilla-b2g/gaia/commit/ee4ecb0b9be1dfaf2ed370562f3154fa06badd64
Status: NEW → RESOLVED
Closed: 11 years ago
Flags: needinfo?(pivanov)
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•