Closed Bug 939660 Opened 11 years ago Closed 6 years ago

remove workaround for bug 937529 in gaia after it is fixed.

Categories

(Firefox OS Graveyard :: Gaia::Gallery, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: johnhu, Assigned: deepsrijit1105, Mentored)

References

Details

(Whiteboard: [good first bug][lang=js])

Attachments

(1 file)

To have semi-transparent circle drawn, the lineJoin is commented out. Once bug 937529 fixed, we need to turn on lineJoin at [1].

[1] https://github.com/mozilla-b2g/gaia/blob/e60d288b45fee64da9934e3b4e6e085b04285b48/apps/gallery/js/ImageEditor.js#L753-L756
Summary: remove workaround of bug 937529 in gaia after it is fixed. → remove workaround for bug 937529 in gaia after it is fixed.
OS: Mac OS X → Gonk (Firefox OS)
Hardware: x86 → ARM
Whiteboard: [good first bug][mentor=johnhu][lang=js]
Depends on: 937529
Hi John Hu, I will be able to do it. Can you please assign this bug to me?
Ram,

Sure. But don't forget to wait for the bug 937529 to be fixed.
Assignee: nobody → vaishnav.rd
Mentor: johu
Whiteboard: [good first bug][mentor=johnhu][lang=js] → [good first bug][lang=js]
Status: NEW → ASSIGNED
Removing myself from assignee for now as I might not be able to work on this when this is ready to pick.
Assignee: vaishnav.rd → nobody
Status: ASSIGNED → NEW
Hi, I'm a beginner .can i work on this ?
Flags: needinfo?(im)
I have made the PR, please assign it to me.
(In reply to Deepa from comment #6)
> I have made the PR, please assign it to me.

Hi Deepa, Thanks a lot for working on this, assigning this to you. Good luck!

- Ram :)
Assignee: nobody → deepsrijit1105
(In reply to Rahul R from comment #4)
> Hi, I'm a beginner .can i work on this ?

Hi Rahul, Thanks for showing your interest but since Deepa has made a pull request here I would request you to work on other bugs. Thanks again for your interest :)

#HappyContributing

- Ram :)
Flags: needinfo?(im)
Hi,

to be honest, Boot2Gecko, Firefox OS, and Gaia, are now dead projects. Deepa, if you want to contribute to Mozilla, I'd recommend finding another project because this project won't move forward and you won't find anybody to review your patch.

Sorry about that :(
To find a project, a good place to start is https://whatcanidoformozilla.org
Hi Julien,

Thanks for your suggestion. :jdm had informed me about the same. I am moving forward with other bugs :-)
Firefox OS is not being worked on
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: