Closed
Bug 939741
Opened 11 years ago
Closed 11 years ago
Firefox fails to build on PPC64: jsatom.cpp:507:24: error: no match for ‘operator<’
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
DUPLICATE
of bug 939504
People
(Reporter: gustavold, Unassigned)
References
Details
Attachments
(1 file)
413 bytes,
patch
|
bhackett1024
:
review+
|
Details | Diff | Splinter Review |
Firefox (m-c) fails to build on PPC64 with the following error message: 1:51.80 /home/buildbot/buildbot/slave/runtests/build/js/src/jsatom.cpp: In function ‘bool js::XDRAtom(js::XDRState<mode>*, js::MutableHandleAtom)’: 1:51.80 /home/buildbot/buildbot/slave/runtests/build/js/src/jsatom.cpp:507:24: error: no match for ‘operator<’ (operand types are ‘JSAtom*(js::ExclusiveContext*, const jschar*, size_t, js::InternBehavior) {aka JSAtom*(js::ExclusiveContext*, const char16_t*, long unsigned int, js::InternBehavior)}’ and ‘js::AllowGC’) The full build log can be found here: http://mozillaproject.osuosl.org:8010/builders/runtests/builds/526/steps/shell/logs/stdio
Reporter | ||
Comment 2•11 years ago
|
||
I applied this patch and tried to build Firefox on PPC64. It fails then on a different place, which seems to be a different issue introduced by changeset 2bbd3a23d40f: 9:16.88 /home/gustavold/upstream/mozilla-central/js/src/jsgc.cpp: In static member function ‘static void* js::gc::ArenaLists::refillFreeList(js::ThreadSafeContext*, js::gc::AllocKind)’: 9:16.88 /home/gustavold/upstream/mozilla-central/js/src/jsgc.cpp:1570:49: error: ‘JSRuntime’ has no member named ‘workerThreadState’ 9:16.88 AutoLockWorkerThreadState lock(*rt->workerThreadState); 9:16.88 ^ 9:16.88 /home/gustavold/upstream/mozilla-central/js/src/jsgc.cpp:1572:21: error: ‘JSRuntime’ has no member named ‘workerThreadState’ 9:16.88 rt->workerThreadState->wait(WorkerThreadState::PRODUCER); 9:16.88 ^ 9:16.88 /home/gustavold/upstream/mozilla-central/js/src/jsgc.cpp:1572:45: error: incomplete type ‘js::WorkerThreadState’ used in nested name specifier 9:16.88 rt->workerThreadState->wait(WorkerThreadState::PRODUCER); 9:16.88 ^ 9:16.92 /home/gustavold/upstream/mozilla-central/js/src/jsgc.cpp: In constructor ‘js::gc::AutoTraceSession::AutoTraceSession(JSRuntime*, js::HeapState)’: 9:16.92 /home/gustavold/upstream/mozilla-central/js/src/jsgc.cpp:4153:45: error: ‘JSRuntime’ has no member named ‘workerThreadState’ 9:16.92 AutoLockWorkerThreadState lock(*rt->workerThreadState); 9:16.92 ^ 9:16.93 /home/gustavold/upstream/mozilla-central/js/src/jsgc.cpp: In destructor ‘js::gc::AutoTraceSession::~AutoTraceSession()’: 9:16.93 /home/gustavold/upstream/mozilla-central/js/src/jsgc.cpp:4169:50: error: ‘JSRuntime’ has no member named ‘workerThreadState’ 9:16.93 AutoLockWorkerThreadState lock(*runtime->workerThreadState); 9:16.93 ^ 9:16.94 /home/gustavold/upstream/mozilla-central/js/src/jsgc.cpp:4173:18: error: ‘JSRuntime’ has no member named ‘workerThreadState’ 9:16.94 runtime->workerThreadState->notifyAll(WorkerThreadState::PRODUCER); 9:16.94 ^ 9:16.94 /home/gustavold/upstream/mozilla-central/js/src/jsgc.cpp:4173:47: error: incomplete type ‘js::WorkerThreadState’ used in nested name specifier 9:16.94 runtime->workerThreadState->notifyAll(WorkerThreadState::PRODUCER); 9:16.94
Attachment #8333862 -
Flags: review?(bhackett1024)
Comment 3•11 years ago
|
||
Comment on attachment 8333862 [details] [diff] [review] Fix build failure on PPC64 Review of attachment 8333862 [details] [diff] [review]: ----------------------------------------------------------------- I think this is a dupe of bug 939504.
Attachment #8333862 -
Flags: review?(bhackett1024) → review+
Reporter | ||
Comment 4•11 years ago
|
||
Yeah, definitely a dupe, though I'm not sure Sparc64 has also hit the issue described in comment #2. Should I file a separate bug for that?
Comment 5•11 years ago
|
||
Can this bug be closed? I think both issues have been fixed on m-c. I am able to build and run m-c on PPC64
Reporter | ||
Comment 6•11 years ago
|
||
Yes, I'm closing as duplicate as indicated on comment #3. Thanks folks.
Status: UNCONFIRMED → RESOLVED
Closed: 11 years ago
Resolution: --- → DUPLICATE
You need to log in
before you can comment on or make changes to this bug.
Description
•