93989 - memory leak in SECMOD_AddModule()

Status: RESOLVED FIXED

(NSS :: Libraries, defect, P2)

Description

[Jeff Hostetler]

in security/nss/lib/pk11wrap/pk11util.c::SECMOD_AddModule(),
the call to _FindModule() returns a 'referenced' module.  this
return value is discarded and hence the reference count is off
and the module gets leaked later during cleanup.

consider adding the following change:

#if 1//begin JLH fix
    SECMODModule * pOldModule = SECMOD_FindModule(newModule->commonName);
    if (pOldModule) {
	/* _FindModule() increased the ref count, so we need to undo it. */
	SECMOD_DestroyModule(pOldModule);
        return SECWouldBlock;
        /* module already exists. */
    }
#else //the old way
    if (SECMOD_FindModule(newModule->commonName)) {
        return SECWouldBlock;
        /* module already exists. */
    }
#endif//end JLH fix

Comment 1

[Keyser Sose]

Need review of patch. thanks for the patch reporter.

Comment 2

[Wan-Teh Chang]

Assigned the bug to Bob.

Comment 3

[Robert Relyea]

Fixed in NSS 3.4