Closed
Bug 940155
Opened 11 years ago
Closed 11 years ago
australis menu support for social marks button
Categories
(Firefox Graveyard :: SocialAPI, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
Firefox 29
People
(Reporter: mixedpuppy, Assigned: mixedpuppy)
References
(Blocks 1 open bug)
Details
(Whiteboard: [Australis:P3])
Attachments
(1 file, 1 obsolete file)
20.97 KB,
patch
|
mixedpuppy
:
review+
|
Details | Diff | Splinter Review |
split out from bug 914921 to simplify the process. Need to make the social mark button work in australis
Updated•11 years ago
|
Whiteboard: [Australis:P3]
Assignee | ||
Comment 1•11 years ago
|
||
https://tbpl.mozilla.org/?tree=Try&rev=94c8bacd998f This basically follows how the status button changes worked in bug 914921, though a listener would not work in this case, something to do with having a custom button and the widget wrapping on it. Watching for the menu panel being shown is good enough as an update mechanism for this button.
Assignee: nobody → mixedpuppy
Attachment #8340173 -
Flags: review?(mhammond)
Comment 2•11 years ago
|
||
Comment on attachment 8340173 [details] [diff] [review] make marks button work in menu panel Review of attachment 8340173 [details] [diff] [review]: ----------------------------------------------------------------- ::: browser/base/content/socialmarks.xml @@ +150,3 @@ > // add our resizer after the dom is ready > + if (!this.inMenuPanel) { > + let DynamicResizeWatcher = Cu.import("resource:///modules/Social.jsm", {}).DynamicResizeWatcher; I know it wasn't before, but I think a lazy getter at the top of the file would be better. @@ +251,5 @@ > // pageData is passed into us. In this case, we always load the iframe > // and show it since the url may not be the browser tab, but an image, > // link, etc. inside the page. We also "update" the iframe to the > // previous url when it is closed. > + let panel = this.panel; this is unused @@ +304,5 @@ > + if (!link || !link.ownerDocument || !rel || !link.href) > + return; > + if (link.rel.indexOf("icon") < 0) > + return; > + trailing whitespace here and a few lines down
Attachment #8340173 -
Flags: review?(mhammond) → review+
Updated•11 years ago
|
Blocks: australis-cust
Assignee | ||
Comment 3•11 years ago
|
||
updated with comments, new try https://tbpl.mozilla.org/?tree=Try&rev=d0b206ab50d3 https://hg.mozilla.org/integration/fx-team/rev/babe33b649a3
Attachment #8340173 -
Attachment is obsolete: true
Attachment #8348521 -
Flags: review+
Assignee | ||
Comment 4•11 years ago
|
||
> updated with comments, new try > https://tbpl.mozilla.org/?tree=Try&rev=d0b206ab50d3 mixing bugs/patches, try is for something else, previous try was in comment 1 is for this patch
Comment 5•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/babe33b649a3
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 29
Updated•10 years ago
|
QA Contact: cornel.ionce
Comment 6•10 years ago
|
||
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:29.0) Gecko/20100101 Firefox/29.0 Verified fixed on latest Aurora (build ID: 20140310004003).
Status: RESOLVED → VERIFIED
Updated•5 years ago
|
Product: Firefox → Firefox Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•