940235 - Build uriloader in unified mode

Status: RESOLVED FIXED

(Core :: DOM: Navigation, defect)

Description

[Chris Peterson [:cpeterson]]

Attachment: unify-uriloader.patch

Comment 1

[Chris Peterson [:cpeterson]]

Comment on attachment 8334395 [details] [diff] [review]
unify-uriloader.patch

oops: patch had link errors related to inconsistent PR_LOGGING definitions.

Comment 2

[Chris Peterson [:cpeterson]]

Unassigning myself because I don't have time to investigate these link errors right now.

Comment 3

[(no longer active)]

Bug 941854 uncovers a bunch of forced NSPR logging here, see:

$ git grep FORCE uriloader/
uriloader/base/nsURILoader.h:21:// #define FORCE_PR_LOG
uriloader/exthandler/nsExternalHelperAppService.cpp:8:#define FORCE_PR_LOG
uriloader/exthandler/nsExternalHelperAppService.h:10:#define FORCE_PR_LOG
uriloader/prefetch/nsOfflineCacheUpdate.cpp:7:#define FORCE_PR_LOG
uriloader/prefetch/nsOfflineCacheUpdateService.cpp:7:#define FORCE_PR_LOG

You should exclude these files from the unified build; that will fix the link issue.  Are you planning on updating your patch?

Comment 4

[Chris Peterson [:cpeterson]]

Attachment: unify-uriloader-v2.patch

Let's try this again:
https://tbpl.mozilla.org/?tree=Try&rev=39cacaff246b

Comment 5

[Chris Peterson [:cpeterson]]

Attachment: R?_940235_unify-uriloader-v3.patch

And then I fixed the Linux compile errors by adding an include guard to nsGNOMERegistry.h:

https://tbpl.mozilla.org/?tree=Try&rev=bf27ee7a666a

Comment 6

[Chris Peterson [:cpeterson]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d4c8a4014d61

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/d4c8a4014d61