940326 - [Linux] New tab button: old assets used in Tab Bar while new assets are used in the Awesomebar

Status: VERIFIED FIXED

(Firefox :: Theme, defect)

Description

[Paul [pwd]]

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux i686; rv:28.0) Gecko/20100101 Firefox/28.0 (Beta/Release)
Build ID: 20131119073913

Steps to reproduce:

The new tab button uses the old assets when in the tab bar but uses the new (winstripe) assets when in the awesome bar.

Comment 1

[:Gijs (he/him)]

I don't think we have new icons for the tabstrip yet. Heck, we don't even have proper Linux icons yet - the icons we use right now are the Windows ones. But there are no more open bugs specifically about the icons on Linux, AFAIK. Stephen?

Comment 2

[Brian Grinstead [:bgrins]]

Could we just use the existing windows icon new tab button (both normal and inverted states) instead of using a linux specific icon?

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

(In reply to Brian Grinstead [:bgrins] from comment #2)
> Could we just use the existing windows icon new tab button (both normal and
> inverted states) instead of using a linux specific icon?

Yeah, we should just do that.

Comment 4

[Tim Nguyen :ntim]

I have an SVG version at [0] if needed.

[0] : https://github.com/nt1m/FirefoxDevToolsSVG/blob/master/browser/

Comment 5

[:Gijs (he/him)]

(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #3)
> (In reply to Brian Grinstead [:bgrins] from comment #2)
> > Could we just use the existing windows icon new tab button (both normal and
> > inverted states) instead of using a linux specific icon?
> 
> Yeah, we should just do that.

Rakhi, can you look at doing this?

Comment 6

[Rakhi(:rakhisharma)]

Yes sure! I will look at this :)

Comment 7

[Rakhi(:rakhisharma)]

Attachment: MozReview Request: Bug 940326 - [Linux] New tab button: old assets used in Tab Bar while new assetsare used in the Awesomebar, r=Gijs

Review commit: https://reviewboard.mozilla.org/r/44565/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/44565/

Comment 8

[:Gijs (he/him)]

Comment on attachment 8738509 [details]
MozReview Request: Bug 940326 - [Linux] New tab button: old assets used in Tab Bar while new assetsare used in the Awesomebar, r=Gijs

https://reviewboard.mozilla.org/r/44565/#review41277

I haven't tested this in-browser, but it looks great to me. One nit below, with that addressed, r=me !

::: browser/themes/linux/jar.mn:101
(Diff revision 1)
> +  skin/classic/browser/tabbrowser/newtab.svg          (tabbrowser/newtab.svg)
> +  skin/classic/browser/tabbrowser/newtab-inverted.svg (tabbrowser/newtab-inverted.svg)

Nit: can you move these two lines down to just before tab-active-middle.png so they're in alphabetical order?

Comment 9

[Rakhi(:rakhisharma)]

Comment on attachment 8738509 [details]
MozReview Request: Bug 940326 - [Linux] New tab button: old assets used in Tab Bar while new assetsare used in the Awesomebar, r=Gijs

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/44565/diff/1-2/

Comment 10

[Rakhi(:rakhisharma)]

Comment on attachment 8738509 [details]
MozReview Request: Bug 940326 - [Linux] New tab button: old assets used in Tab Bar while new assetsare used in the Awesomebar, r=Gijs

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/44565/diff/2-3/

Comment 11

[Rakhi(:rakhisharma)]

Comment on attachment 8738509 [details]
MozReview Request: Bug 940326 - [Linux] New tab button: old assets used in Tab Bar while new assetsare used in the Awesomebar, r=Gijs

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/44565/diff/3-4/

Comment 12

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d34db6d094d8

Comment 13

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e6d9e7a97079

Comment 14

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/d34db6d094d8
https://hg.mozilla.org/mozilla-central/rev/e6d9e7a97079

Comment 15

[Matthew N. [:MattN]]

Looks good. I skimmed a few of the screenshots comparisons and didn't see any obvious issues:
http://screenshots.mattn.ca/compare/?oldProject=mozilla-central&oldRev=68c0b7d6f16ce5bb023e08050102b5f2fe4aacd8&newProject=mozilla-central&newRev=b6683e141c47c022598c0caac3ea8ba8c6236d42

Comment 16

[Nazir Ahmed Sabbir [:NaSb]]

I've managed to reproduce this bug on Nightly 28.0a1 (2013-11-19) on Linux, 64 Bit.

Bug is now verified as fixed on Latest Firefox Developer Edition 48.0a2 (2016-05-09)

Build ID: 20160509004024
User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:48.0) Gecko/20100101 Firefox/48.0
OS: Linux 3.19.0-58-generic x86-64