940496 - Write a test to open a window from inside an iframe

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::UI Tests, defect, P2)

Description

[Zac C (:zac)]

Test case:

1. Open UI tests app
2. Scroll down and open "window.open"
3. Scroll down to "Call on this iframe within mozbrowser"
4. Tap "window.open" button
5. Assert that window has opened
6. Tap [X] in top right corner to close the window
7. Assert that it has closed.

Enable this test for Travis and if possible TBPL.

Comment 1

[poaksdasd]

Hello! I would like to take this bug as my first.

Comment 2

[Florin Strugariu [:Bebe]]

Michael can we help you with this task?

Comment 3

[poaksdasd]

Sure. I am still trying to figure out how to connect it all.

Comment 4

[Robert Chira [:RobertC]]

Hi, is anyone working on this task? If not I would like to take it.

Comment 5

[Florin Strugariu [:Bebe]]

I will assign this to Robert

Comment 6

[Robert Chira [:RobertC]]

Attachment: Pull request

Comment 7

[Zac C (:zac)]

Comment on attachment 8365984 [details] [review]
Pull request

thanks Robert, r? me again when you've made those changes and I'll review it again

Comment 8

[Zac C (:zac)]

Comment on attachment 8365984 [details] [review]
Pull request

r- some more nits

Comment 9

[Florin Strugariu [:Bebe]]

Comment on attachment 8365984 [details] [review]
Pull request

This is failing on Travis

Comment 10

[Bob Silverberg [:bsilverberg]]

Comment on attachment 8365984 [details] [review]
Pull request

Comments in the PR.

Comment 11

[Florin Strugariu [:Bebe]]

Comment on attachment 8365984 [details] [review]
Pull request

fix the nit's and we are ok

Comment 12

[Bob Silverberg [:bsilverberg]]

Comment on attachment 8365984 [details] [review]
Pull request

LGTM. Let's merge when the tree reopens.

Comment 13

[Florin Strugariu [:Bebe]]

Merged in:
https://github.com/mozilla-b2g/gaia/commit/821e961be1264c1f37db3f5750df9c76f83e10cc

Comment 14

[[:AndreiH]]

Comment on attachment 8365984 [details] [review]
Pull request

I see this was resolved