941018 - Infinite loop in codemirror.js:973

Status: RESOLVED FIXED

(DevTools :: Source Editor, defect, P1)

Description

[Paul Rouget [:paul]]

Attachment: screenshot

While using the style editor with the split console, firefox got stuck. I think it happened when I clicked on the CSS filename in the webconsole, but I'm not sure (see screenshot).

The same thing happened a bit later when closing a Firefox window with an opened Style Editor.

No obvious STR.

Comment 1

[Anton Kovalyov (:anton)]

STR:

1. Open any tool other than StyleEditor.
2. Open console, enable CSS messages.
3. Click on the file-name link.

Firefox now freezes. After a while, a slow script dialog pointing to the measureChar function pops up.

Comment 2

[Anton Kovalyov (:anton)]

Attachment: Add default value for col in selectStyleSheet

This bug was caused by the selectStyleSheet function not expecting undefined as a value for its third formal parameter (col). It then tried to subtract from undefined which produced NaN which was passed, incorrectly, to the Editor instance. My patch fixes that.

Comment 3

[Anton Kovalyov (:anton)]

https://hg.mozilla.org/integration/fx-team/rev/10a42de21755

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/10a42de21755

Comment 5

[Anton Kovalyov (:anton)]

Comment on attachment 8338197 [details] [diff] [review]
Add default value for col in selectStyleSheet

[Approval Request Comment]
Bug caused by (feature/regressing bug #): N/A
User impact if declined: In some cases, opening a stylesheet from the console will freeze the browser.
Testing completed (on m-c, etc.): m-c, local.
Risk to taking this patch (and alternatives if risky): None. The patch simply adds a default value to a parameter + regression test case.
String or IDL/UUID changes made by this patch: N/A

Comment 6

[bhavana bajaj [:bajaj]]

Comment on attachment 8338197 [details] [diff] [review]
Add default value for col in selectStyleSheet

low risk patch for a Fx27 regression, approving on aurora

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/9dc220412fa7