941046 - Add test to ensure Fitts Law works on the Back button on Windows

Status: RESOLVED FIXED

(Firefox :: Theme, defect)

Description

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: backButtonTest.patch

Bug 571454 added code to specifically support clicking on the first pixel of the window when in maximized mode so that it would trigger hitting the back button on a default profile in Windows.

We should have a test that verifies this behavior exists and doesn't regress.

Pushed to tryserver: https://tbpl.mozilla.org/?tree=Try&rev=5bdfc9acf79e

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

All green on Tryserver.

Comment 2

[:Felipe Gomes (needinfo for replies!)]

Comment on attachment 8335344 [details] [diff] [review]
backButtonTest.patch

Review of attachment 8335344 [details] [diff] [review]:
-----------------------------------------------------------------

r+, but I would suggest listening for a "popstate" event instead of waitForCondition, to make the test more deterministic and also more e10s friendly.

::: browser/base/content/test/general/browser_backButtonFitts.js
@@ +20,5 @@
> +    EventUtils.synthesizeMouseAtPoint(xPixel, yPixel, {}, window);
> +    var condition = function() gBrowser.selectedBrowser.contentDocument.location.href == firstLocation;
> +    waitForCondition(condition,
> +      () => {
> +        ok(condition(), "Clicking the first pixel should have navigated back.");

no need to re-run condition, you could just have ok(true, ...) here

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

https://hg.mozilla.org/integration/fx-team/rev/916737f3bb20

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/916737f3bb20