94123 - expand our support for the Vary header

Status: RESOLVED FIXED

(Core :: Networking, enhancement)

Description

[Darin Fisher]

mozilla does not fully implement the Vary header.  we are not violating the spec
with our implementation, but we are also not taking advantage of it either.

we should really be storing the value's of the request headers, specified by
Vary response header, in the cache entry's meta data.  then when making a new
request for the same URL, we'd be able to compare the request headers to see if
the cached response could be used.

currently, we just ignore a cached response that contains a Vary header matching
request headers that could change, either via prefs or some API.  but, the
headers we compare are hardcoded and this prevents our Vary header support from
being dynamic -- ie. based on the headers that we really do send.

Comment 1

[Darin Fisher]

-> future

Comment 2

[Brant Gurganus]

[RFE] is deprecated in favor of severity: enhancement.  They have the same meaning.

Comment 3

[Christian :Biesinger (don't email me, ping me on IRC)]

how does this bug relate to bug 132957? Is it a duplicate?

Comment 4

[Alfred Kayser]

Darin, looking at the current code it allready seems to the above.
This can be closed?

Comment 5

[Thomas Rutter]

*** Bug 236718 has been marked as a duplicate of this bug. ***

Comment 6

[Thomas Rutter]

I posted bug #236718, turns out it was a duplicate of this bug.

It would be nice if Mozilla supported "Vary: Cookie".  Currently, no major
browser supports this correctly.  Mozilla treats it like "Vary: *", which
doesn't break the specification, but hampers caching in dynamic pages (pages
always require re-validation).

Comment 7

[Darin Fisher]

-> default owner

Comment 8

[Bjarne (:bjarne)]

I'll grab this as a followup to bug #510359

Comment 9

[Bjarne (:bjarne)]

I'm closing this one since bug #468426 landed. Let's handle special cases in separate bugs.