941307 - Remove region selector from user settings

Status: VERIFIED FIXED

(Marketplace Graveyard :: Consumer Pages, defect, P2)

Description

[Christopher Van Wiemeersch [:cvan]]

All apps (existing/new free apps) are included in every region by default. The developer has to explicitly go into the DevHub and change from "Make my available in most regions" to "Choose where my app is made available" in order to georestrict his/her app to particular regions.

Because we are excluding georestricted content (and not marking the content as "unavailable"), the region switcher becomes obsolete because all content that was previously available in only particular regions is now available everywhere. The only possible reason a user would want to change his/her region is to see an app that is explicitly georestricted. And if it's a georestricted app, that means that we look at the user's SIM/IP address and ensure that the user is viewing from a region from which the app developer has permitted access. In short, the region selector no longer serves a purpose. If we were marking content as "unavailable" and not excluding georestricted apps, then the region selector would be useful. But we're not, and it's not.

(See bug 940561 for further discussion.)

QA should still have an option to select the override the region selection.

Comment 1

[Christopher Van Wiemeersch [:cvan]]

https://github.com/mozilla/fireplace/commit/aaf8db6
https://github.com/mozilla/fireplace/commit/086627f
https://github.com/mozilla/fireplace/commit/5f6a22c 

Thanks, Basta, for the first patch!


Notes
-----
* Users should no longer see a <select> menu on the settings page allowing them to change their regions.
* On desktop: looking in the footer, users should see a flag that links to the settings page, where we list only the region and its flag, no <select> menu.
* On mobile: clicking on the settings gear, users should see only the region and its flag, no <select> menu.
* Existing users' saved region selections (in localStorage) should be removed/ignored, as we're now instead relying on SIM and IP geolocation to set users' regions.


QA
--
* On desktop: search for ":debug" (or hold the logo for 3 seconds) and a <select> menus for Region/Carrier appear.
* On mobile: hold the logo for 3 seconds and <select> menus for Region/Carrier appear.

Comment 2

[Victor Carciu]

Verified as fixed : http://screencast.com/t/fZpXR1qiU

Comment 3

[Christopher Van Wiemeersch [:cvan]]

Reverted until bug 941939 is properly fixed: https://github.com/mozilla/fireplace/commit/859ef80

Comment 4

[Christopher Van Wiemeersch [:cvan]]

Reverted the revert: https://github.com/mozilla/fireplace/commit/c82b6b9

Comment 5

[Bob Silverberg [:bsilverberg]]

We have a couple of tests in our marketplace-tests repo for gaia which are meant to test changing the region. It sounds like these tests are no longer required and should be deleted, or should they be changed to use the "hidden" method mentioned above? Regarding that, I tried "On mobile: hold the logo for 3 seconds and <select> menus for Region/Carrier appear." on Firefox OS but wasn't able to get a select menu. Is this meant to work on Firefox OS, and if so, exactly where is this logo that we are meant to click on?

Comment 6

[krupa raj[:krupa]]

(In reply to Bob Silverberg [:bsilverberg] from comment #5)
> We have a couple of tests in our marketplace-tests repo for gaia which are
> meant to test changing the region. It sounds like these tests are no longer
> required and should be deleted, or should they be changed to use the
> "hidden" method mentioned above? Regarding that, I tried "On mobile: hold
> the logo for 3 seconds and <select> menus for Region/Carrier appear." on
> Firefox OS but wasn't able to get a select menu. Is this meant to work on
> Firefox OS, and if so, exactly where is this logo that we are meant to click
> on?

That feature has since been disabled. 

To get to the debug page, just enter :debug in the search box which will load the /debug page. You can change the region from there.

Comment 7

[Federico 'klez' Culloca]

This test case (https://moztrap.mozilla.org/results/case/39122/) should be changed to mention that the region is not editable and is not a drop down anymore.

Comment 8

[Daniele "Mte90" Scasciafratte]

Confirm for the test case