Closed
Bug 941406
Opened 11 years ago
Closed 11 years ago
Build netwerk/dns in unified mode
Categories
(Core :: Networking, defect)
Core
Networking
Tracking
()
RESOLVED
FIXED
mozilla28
People
(Reporter: mz_mhs-ctb, Assigned: mz_mhs-ctb)
References
Details
(Whiteboard: [qa-])
Attachments
(1 file, 2 obsolete files)
917 bytes,
patch
|
Details | Diff | Splinter Review |
No description provided.
Attachment #8335794 -
Flags: review?(ehsan)
Comment 2•11 years ago
|
||
Comment on attachment 8335794 [details] [diff] [review] Patch Review of attachment 8335794 [details] [diff] [review]: ----------------------------------------------------------------- Why are you not unifying the files in SOURCES here? If you have a good reason you should add that as a comment to the SOURCES variable. Note that we can unify C files together and C++ files together as well, you can just put them all in UNIFIED_SOURCES and the build system will figure it out.
Attachment #8335794 -
Flags: review?(ehsan)
Oh. I was thinking that there might be more bustage (you tactfully informed me of this at bug 940153 comment 6) due to files with special build flags, bug 939615.
Comment 4•11 years ago
|
||
(In reply to comment #3) > Oh. I was thinking that there might be more bustage (you tactfully informed me > of this at bug 940153 comment 6) due to files with special build flags, bug > 939615. You're right about nsEffectiveTLDService.cpp, but what about the .c files there? (And note that you should still say why you're exlcuding nsEffectiveTLDService.cpp in the comment.)
Attachment #8335794 -
Attachment is obsolete: true
Attachment #8335842 -
Flags: review?(ehsan)
Updated•11 years ago
|
Attachment #8335842 -
Flags: review?(ehsan) → review+
Attachment #8335842 -
Attachment is obsolete: true
Keywords: checkin-needed
Comment 7•11 years ago
|
||
Pushed a follow-up fix for a warnings-as-errors bustage: https://hg.mozilla.org/integration/mozilla-inbound/rev/2d8d46e3e15c
Keywords: checkin-needed
Comment 9•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/b4867e279d3c https://hg.mozilla.org/mozilla-central/rev/2d8d46e3e15c
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
Updated•10 years ago
|
Whiteboard: [qa-]
You need to log in
before you can comment on or make changes to this bug.
Description
•