Closed Bug 94151 Opened 23 years ago Closed 23 years ago

nsBidiPresUtils::FormatUnicodeText can return uninitialized nsresult

Categories

(Core :: Layout: Text and Fonts, defect)

Product:
Core
Component:
Layout: Text and Fonts
Platform:
x86
Linux
Type:
defect
Priority:
Not set
Severity:
trivial

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: mozilla-bugs, Assigned: mkaply)

References

(
URL
)

Details

nsBidiPresUtils::FormatUnicodeText declares and returns "nsresult rv", however
this variable is only initialized on one (of many) code execution path. Hence,
the declaration should be changed from

nsresult rv;

to 

nsresult rv = NS_OK;
Blocks: 59652
reassign to mkaply@us.ibm.com
Assignee: erik → mkaply
Component: Layout → BiDi Hebrew & Arabic
For some reason this bug never turned up on my radar before today. Marking
dependence on bug 81664 since the patch in attachment 40880 [details] [diff] [review] contains the
required initialization.
Depends on: 81664
Fixed by 81664
Status: NEW → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
Component: Layout: BiDi Hebrew & Arabic → Layout: Text
QA Contact: chrispetersen → layout.fonts-and-text
You need to log in before you can comment on or make changes to this bug.