941590 - Build jsapi-tests in unified mode

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jan de Mooij [:jandem]]

Attachment: Patch

There's a whole bunch of them and this should hopefully make building the shell and browser slightly faster.

There was only one real problem: two tests used a |callCount| variable. I cleaned up a bunch of other tests too though, in particular moving functions between BEGIN_TEST and END_TEST makes them class members, making them less likely to clash with other tests in the future.

Comment 1

[(no longer active)]

Comment on attachment 8336002 [details] [diff] [review]
Patch

Review of attachment 8336002 [details] [diff] [review]:
-----------------------------------------------------------------

(Note that I only skimmed the code changes, but everything looks good to me!)

Comment 2

[Jan de Mooij [:jandem]]

https://tbpl.mozilla.org/?tree=Try&rev=63ac02a8aee8

Comment 3

[Jan de Mooij [:jandem]]

Try looks good, pushed:

https://hg.mozilla.org/integration/mozilla-inbound/rev/371af5899d27

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/371af5899d27