941725 - Add emacs and vim key bindings to source editor

Status: RESOLVED FIXED

(DevTools :: Source Editor, defect, P3)

Description

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Would be cool if we had a dropdown in the options panel to choose different keybinding styles for inside the source editor. Specifically, one of those should be emacs style keybindings. Should be easy since there's a mode/plugin/something for code mirror, right?

Comment 1

[Anton Kovalyov (:anton)]

This is not P2 at all.

Comment 2

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

(In reply to Anton Kovalyov (:anton, @valueof) from comment #1)
> This is not P2 at all.

It is assigned, therefore P2. And you said it would take like five minutes last night.

Comment 3

[Brandon Benvie [:benvie]]

All you need to do is plop this bad boy in: https://github.com/marijnh/CodeMirror/blob/master/keymap/emacs.js.

Comment 4

[Anton Kovalyov (:anton)]

Attachment: WIP 1

This patch adds Emacs and VIM keymaps to our source editor. Since CodeMirror architecture is obviously different from both Emacs and VIM, the support is approximate.

I also added a new event, save, that is triggered whenever a save command is called. In VIM mode it is with :w so you get this kind of interaction: http://vimeo.com/83533549

Reviews: benvie for scratchpad, mihai for sourceeditor and harth for styleeditor changes.

Comment 5

[Heather Arthur [:harth]]

Comment on attachment 8356249 [details] [diff] [review]
WIP 1

Review of attachment 8356249 [details] [diff] [review]:
-----------------------------------------------------------------

r=me for style editor change.

Comment 6

[Anton Kovalyov (:anton)]

Attachment: WIP 2

Rebased with the current fx-team and added keymap/ files to codemirror/README. Carrying over harth's r+.

Comment 7

[Brandon Benvie [:benvie]]

Comment on attachment 8356268 [details] [diff] [review]
WIP 2

Review of attachment 8356268 [details] [diff] [review]:
-----------------------------------------------------------------

Scratchpad changes LGTM.

Comment 8

[Mihai Sucan [:msucan]]

Comment on attachment 8356268 [details] [diff] [review]
WIP 2

Review of attachment 8356268 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM and I am glad to see vim mode. I like that - it seems good enough.

Comment 9

[Mihai Sucan [:msucan]]

Do you plan to add some tests for these new key maps?

Comment 10

[Anton Kovalyov (:anton)]

> Do you plan to add some tests for these new key maps?

Good point. CodeMirror has its own tests for both VIM and Emacs bindings. I will add them to this patch and then will figure out the way to integration test this.

Comment 11

[Anton Kovalyov (:anton)]

Attachment: WIP 3

Added CM tests for both Emacs and VIM mode. Since this adds a lot of new tests, running a Try to make sure we're not timing out on Linux machines: https://tbpl.mozilla.org/?tree=Try&rev=4a9d3d89279a

Carrying over r+ from harth, benvie and msucan.

Comment 12

[Anton Kovalyov (:anton)]

https://hg.mozilla.org/integration/fx-team/rev/f122349d9fbd

Comment 13

[Kostas]

Will this feature also be available in Nightly for windows?
Or it's for Mac OS X only?

Comment 14

[Anton Kovalyov (:anton)]

It is available on all platforms.

Comment 15

[Anton Kovalyov (:anton)]

This was landed in m-c by the way.

Comment 16

[Anton Kovalyov (:anton)]

Actually, I can't find it in m-c. Was it ever merged or backed out?

Comment 17

[Anton Kovalyov (:anton)]

Nvm, seems like it was backed out here: https://github.com/mozilla/gecko-dev/commit/43291099f8264f6782f42a25fc5208c036e695f7

Comment 18

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Yeah, looks like this was backed out in https://hg.mozilla.org/integration/fx-team/rev/ad44a7aa67e1 but that comment never ended up here.

Comment 19

[Anton Kovalyov (:anton)]

Landing again, with VIM/Emacs addon tests disabled: https://hg.mozilla.org/integration/fx-team/rev/c15cacb7efd6 They will be re-enabled once we split codemirror.html into multiples. (At this point we have to.)

Comment 20

[Matt Brubeck (:mbrubeck)]

Sorry, backed out because of CodeMirror test failures again:
https://hg.mozilla.org/integration/fx-team/rev/31f20a54082f

https://tbpl.mozilla.org/?tree=Fx-Team&rev=c15cacb7efd6

Comment 21

[Anton Kovalyov (:anton)]

Attachment: vim.patch

So, I split CodeMirror test suite into two: one for all basic tests, another for VIM/Emacs modes only. It seems to be running well on my machine, pushing to Try and if it's green going to land this tomorrow. Again.

https://tbpl.mozilla.org/?tree=Try&rev=b11f1947ca30

Comment 22

[Anton Kovalyov (:anton)]

Ok, third attempt. Try seemed to be green.

https://hg.mozilla.org/integration/fx-team/rev/fd0dafa0e8db

Comment 23

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/fd0dafa0e8db