942937 - Deprecation warning "PlacesBackups.getMostRecent is deprecated and will be removed in a future version" in nsSuiteGlue.js (port bug 859695)

Status: RESOLVED FIXED

(SeaMonkey :: Bookmarks & History, defect)

Description

[Stefan Sitter [:ssitter]]

Mozilla/5.0 (Windows NT 6.1; WOW64; rv:28.0) Gecko/20100101 Firefox/28.0 SeaMonkey/2.25a1 (BuildID: 20131124011553)

When opening e.g. Tools > Add-ons Manager I get various deprecation errors in console:

Error: DEPRECATION WARNING: PlacesBackups.getMostRecent is deprecated and will be removed in a future version. You may find more details about this deprecation at: https://bugzilla.mozilla.org/show_bug.cgi?id=859695
resource://gre/modules/PlacesBackups.jsm 194 PB_getMostRecent
resource://gre/components/nsSuiteGlue.js 710 null
resource://gre/components/nsSuiteGlue.js 196 null

Error: DEPRECATION WARNING: PlacesBackups.entries is deprecated [...]

Error: DEPRECATION WARNING: PlacesBackups.folder is deprecated [...]

Comment 1

[Jens Hatlak (:InvisibleSmiley)]

(In reply to Stefan Sitter from comment #0)
> Error: DEPRECATION WARNING: PlacesBackups.entries is deprecated [...]
> 
> Error: DEPRECATION WARNING: PlacesBackups.folder is deprecated [...]

At least as far as the nsSuiteGlue.js:710 occurrence is concerned, these are only due to getMostRecent() being called in the first place.

Otherwise, all this is just trying to tell us that we need to port bug 859695. Since that has TM mozilla27, I guess any SM version beginning with 2.24 (now on Beta) is affected (by the deprecation warnings; nothing has been removed yet, not even on trunk).

Comment 2

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows NT 6.0; rv:33.0) Gecko/20100101 Firefox/33.0 SeaMonkey/2.30; 20141013232806]
{
Erreur : DEPRECATION WARNING: PlacesBackups.getMostRecent is deprecated and will be removed in a future version
You may find more details about this deprecation at: https://bugzilla.mozilla.org/show_bug.cgi?id=859695
resource://gre/modules/PlacesBackups.jsm 263 PB_getMostRecent
resource://gre/components/nsSuiteGlue.js 723 SuiteGlue.prototype._initPlaces
resource://gre/components/nsSuiteGlue.js 199 SuiteGlue.prototype.observe
null 0 null

Fichier Source : resource:///modules/Deprecated.jsm
Ligne : 79
}

Comment 3

[Mark Banner (:standard8)]

Note: this code is going away in bug 1433979 - likely to land in the next day or so. It should be easy to copy from nsBrowserGlue.js where this affects, although you might need to check for other call locations.

Comment 4

[Frank-Rainer Grahl (:frg)]

Thanks. I did a wip patch some time ago. Will look into it.

Comment 5

[Frank-Rainer Grahl (:frg)]

Attachment: 942937-part1-profileshutdown-257.patch

part 1 for sports

Comment 6

[Frank-Rainer Grahl (:frg)]

Attachment: 942937-part2-placesinit-257.patch

part 2 breakage fix

Comment 7

[Frank-Rainer Grahl (:frg)]

Attachment: 942937-part1-profileshutdown-253.patch

2.53 version part 1

Comment 8

[Frank-Rainer Grahl (:frg)]

Attachment: 942937-part2-placesinit-253.patch

2.53 version part 2

Comment 9

[Frank-Rainer Grahl (:frg)]

Should we keep the lock strings in notification.properties or match Fx as in this bug? Not an exact match because we show a notification but otherwise almost identical.

Comment 10

[Frank-Rainer Grahl (:frg)]

Attachment: 942937-part1-profileshutdown-257.patch

Rebased after Bug 1436605 landed.

Comment 11

[Frank-Rainer Grahl (:frg)]

Attachment: 942937-part2-placesinit-257.patch

Rebased after Bug 1436605 landed.

Comment 12

[Ian Neal]

(In reply to Frank-Rainer Grahl (:frg) from comment #9)
> Should we keep the lock strings in notification.properties or match Fx as in
> this bug? Not an exact match because we show a notification but otherwise
> almost identical.

Having them just in places.properties is fine.

Comment 13

[Frank-Rainer Grahl (:frg)]

Comment on attachment 8955778 [details] [diff] [review]
942937-part1-profileshutdown-257.patch

[Approval Request Comment]
Regression caused by (bug #): Bug 967839 
User impact if declined: bookmarks backup not working possible startup crash
Testing completed (on m-c, etc.): 2.53 
Risk to taking this patch (and alternatives if risky): --
String changes made by this patch: --

Comment 14

[Frank-Rainer Grahl (:frg)]

Comment on attachment 8955779 [details] [diff] [review]
942937-part2-placesinit-257.patch

[Approval Request Comment]
Regression caused by (bug #): Bug 967839 
User impact if declined: bookmarks backup not working possible startup crash
Testing completed (on m-c, etc.): 2.53 
Risk to taking this patch (and alternatives if risky): --
String changes made by this patch: --

Comment 15

[Frank-Rainer Grahl (:frg)]

Comment on attachment 8955779 [details] [diff] [review]
942937-part2-placesinit-257.patch

Regression actually cuased by Bug 1433979. Comment is correct.

Comment 16

[Ian Neal]

Comment on attachment 8955778 [details] [diff] [review]
942937-part1-profileshutdown-257.patch

LGTM r/a=me

Comment 17

[Ian Neal]

Comment on attachment 8955779 [details] [diff] [review]
942937-part2-placesinit-257.patch

LGTM r/a=me

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/aad618543d32
Move onProfileShutdown logic to quit-application-granted phase. r=IanN
https://hg.mozilla.org/comm-central/rev/1ad208ac3369
Clean up places init and remove deprecated PlacesBackups calls. r=IanN

Comment 19

[Frank-Rainer Grahl (:frg)]

https://hg.mozilla.org/releases/comm-beta/rev/85fef84f3604
https://hg.mozilla.org/releases/comm-beta/rev/e7ec4d4f2a40

Comment 21

[Frank-Rainer Grahl (:frg)]

Fixed in 2.53.1
https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commits/2_53_1_final