943198 - B2G RIL: [DSDS] Follow-up of bug 814637 - enable new marionette tests of IccManager

Status: RESOLVED FIXED

(Firefox OS Graveyard :: RIL, defect)

Description

[Edgar Chen [:edgar]]

+++ This bug was initially created as a follow-up of Bug #814637 +++

In bug 814637, we have added two new test cases for new IccManager's API.
- test_icc_access_invalid_object.js
- test_icc_detected_undetected_event.js

But they were disabled temporarily due to bug 933654 (Please see bug 814637 comment #74).

We should enable it back after bug 933654 is fixed.

Comment 1

[Edgar Chen [:edgar]]

Attachment: Patch, v1

Comment 2

[Edgar Chen [:edgar]]

Comment on attachment 8338387 [details] [diff] [review]
Patch, v1

1). Enable below test cases,
    - test_icc_access_invalid_object.js
    - test_icc_detected_undetected_event.js
2). Use the MobileConnection API to enable/disable radio.
3). Try result is good: https://tbpl.mozilla.org/?tree=Try&rev=9ef6137cf2fc

Comment 3

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Comment on attachment 8338387 [details] [diff] [review]
Patch, v1

Review of attachment 8338387 [details] [diff] [review]:
-----------------------------------------------------------------

Nice!

Comment 4

[Edgar Chen [:edgar]]

Attachment: Patch, v2, r=hsinyi

Rebase only.

Comment 5

[Edgar Chen [:edgar]]

try server: https://tbpl.mozilla.org/?tree=Try&rev=922fb594131e

Comment 6

[Edgar Chen [:edgar]]

https://hg.mozilla.org/integration/b2g-inbound/rev/755b42fa10eb

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/755b42fa10eb