943389 - [Dialer][Conference call] Detailed contact info on conference call on group line is missing

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Description

[isabelrios]

Attachment: originalvsscreenshot_2.png

v1.2 11/26 build:
Gecko-6ac8a1e
Gaia-264c604

1. Start a call with a contact
2. Call to another contact
3. Merge both calls

EXPECTED
Below the Group call label, there should appear the contact information. Please see on attached file originavsscreenshot: 'original desing'

ACTUAL
Nothing about the contacts (or number) called is shown, please see 'conference call' screenshot attached

Comment 1

[isabelrios]

Attachment: Conference call screenshot.png

Latest screenshot of the conference call screen

Comment 2

[Preeti Raghunath(:Preeti)]

David,

Please assign an engineer to the same.

Comment 3

[Noemí Freire (:noemi)]

removing koi? flag per comment https://bugzilla.mozilla.org/show_bug.cgi?id=923646#c16 and ni? to Jaqueline in order she can set up the expected flag here. Thanks!

Comment 4

[Jacqueline Savory [:jsavory] UX]

Since this one was pushed from koi, hopefully we can complete this for 1.3.

Comment 5

[David Scravaglieri [:scravag]]

this will be discussed during triage

Comment 6

[Joe Cheng [:jcheng] (please needinfo)]

triage: minus. let's fix it in 1.4 but not blocking release.

Comment 8

[Germán Toro del Valle (:gtorodelvalle)]

Hi Carol, would you be so kind to point me to the main ongoing conference call page specs related to this bug? If it still applies including the names of the participants on that main page, of course :) Thanks!

Comment 9

[Carol Huang [:Carol]]

Attachment: SPEC.Call_Conferencecallwaiting_Expandableareas.png

Hi Germán,
The screenshot are the visuals before visual refresh, right?

I'll attach the Visual spec for Conference call screen.
Please use the new graphic assets.
Let me know if you still need any other information. Thanks!

Comment 10

[Germán Toro del Valle (:gtorodelvalle)]

Attachment: SPEC.Call_Incall_Expandableareas.png

Hey Carol! The spec you mention (attachment 8470503 [details]) applies when there is an additional call apart from the conference call itself, right? :)
In case the conference call is the only ongoing call, I guess the spec to apply is the one I am attaching here, right? :)
Thanks!

Comment 11

[Carol Huang [:Carol]]

Hi Germán,
Yes, if the conference call is the only ongoing call, the spec you attached (attachment 8470817 [details]) is correct.
Thank you!:)

Comment 12

[Germán Toro del Valle (:gtorodelvalle)]

Thanks! Jorge is currently working on this bug based on the provided specs ;)

Comment 13

[Jorge Prudencio [:jorgep]]

Hi Carrie,

What name format do I have to show on contact details? Do I have show the full name of the contact?

Thanks!

Comment 14

[Carrie Wang [New account: [e-mail]]]

Hi Jorge, 

We should display what users exactly set for that contact. So if user set the contact with the full name (first name + last name), we will display it on call pages (in every different scenarios). Thanks!

Comment 15

[Jorge Prudencio [:jorgep]]

Attachment: [screenshot] Merge two calls.png

Comment 16

[Jorge Prudencio [:jorgep]]

Attachment: [screenshot] Conference.png

Comment 17

[Jorge Prudencio [:jorgep]]

Attachment: [screenshot] Merge conference with call.png

Comment 18

[Jorge Prudencio [:jorgep]]

Attachment: 22875.html

Comment 19

[Carol Huang [:Carol]]

Comment on attachment 8472869 [details]
[screenshot] Merge two calls.png

Looks good! thank you, Jorge!

Comment 20

[Germán Toro del Valle (:gtorodelvalle)]

Comment on attachment 8472878 [details]
22875.html

There are some test cases not passing due to this patch as you can see at https://tbpl.mozilla.org/?rev=a4e73cee96e180ce4d3e16ae740a3eb0429743ba&tree=Gaia-Try We'll deal with them in person as well as with other issues I would like to comment ;)

Comment 21

[Jorge Prudencio [:jorgep]]

Attachment: 23266.html

Comment 22

[Germán Toro del Valle (:gtorodelvalle)]

Comment on attachment 8478183 [details]
23266.html

I left some comments in Github ;) attachment 8478183 [details]

Comment 23

[Germán Toro del Valle (:gtorodelvalle)]

Comment on attachment 8478183 [details]
23266.html

Just a minor comment on Github, please include it ;) Anyhow f+ :) Please, ask a peer for the final revision ;) Thanks!

Comment 24

[Anthony Ricaud (:rik)]

Comment on attachment 8478183 [details]
23266.html

We have an L10n issue with this patch.

Also, I haven't tested on a device but I'm surprised we don't need to add some text-overflow CSS.

Comment 25

[Vishnu Teja [:ythej]]

Hi Doug,

I would like to work on this bug.Is there anyone still working on this bug or is it okay if I take it.

Thank you.

Comment 26

[Vishnu Teja [:ythej]]

Hi Doug,

I see that we can't reproduce it using mulet.I don't have a device.

Sorry that I can't help.

Thanks.

Comment 27

[BMO Automation]

Firefox OS is not being worked on