943571 - Write a test for bug 940446

Status: RESOLVED FIXED

(Firefox :: Search, defect)

Comment 1

[Steven MacLeod [:smacleod]]

Attachment: Patch - Add a test for ignoring an invalid engine loaded from a dir

This patch adds a test for the failure case using the engine dbaron provided.

The test fails before the patch in Bug 940446 and passes after it has been applied.

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 8342174 [details] [diff] [review]
Patch - Add a test for ignoring an invalid engine loaded from a dir

>diff --git a/toolkit/components/search/tests/xpcshell/data/old-sherlock-google.xml b/toolkit/components/search/tests/xpcshell/data/old-

>+# Mozilla/Google plug-in by [e-mail]
>+# File provided in Bug 940446

It's probably not necessary to copy this file exactly - any "invalid" file will do, so an xml file that is empty or is gibberish would be sufficient

>diff --git a/toolkit/components/search/tests/xpcshell/test_invalid_engine_from_dir.js b/toolkit/components/search/tests/xpcshell/test_invalid_engine_from_dir.js

>+function run_test() {

>+  do_load_manifest("data/chrome.manifest");
>+
>+  let url  = "chrome://testsearchplugin/locale/searchplugins/";
>+  Services.prefs.setCharPref("browser.search.jarURIs", url);
>+  Services.prefs.setBoolPref("browser.search.loadFromJars", false);

These lines have been treated as boilerplate but they're only necessary for testing JAR-loaded plugins - so they shouldn't be necessary here.

r=me with those addressed, sorry for the delay.

Comment 3

[Steven MacLeod [:smacleod]]

Attachment: b943571.patch

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1e3bcdef8157

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/1e3bcdef8157