944075 - /revisions/ page doesn't show who made the most recent change to a rule

Status: RESOLVED FIXED

(Release Engineering Graveyard :: Applications: Balrog (frontend), defect)

Description

[[e-mail] (:bhearsum)]

(Might apply to releases too, I'm not sure if that code is generic.)

Eg: https://aus4-admin.mozilla.org/rules/18/revisions/ shows 5 versions of that rule. I happen to know that Nick made the most recent change, but it doesn't show up in the UI...

Comment 2

[Nick Thomas [:nthomas] (UTC+12)]

Bug 944083 also has suggestions for the ordering of the table, and how to display dates of changes.

Comment 3

[[e-mail] (:bhearsum)]

I don't think this truly blocks moving beta users to balrog, but it is fairly important.

Comment 4

[Massimo Gervasini [:massimo]]

Attachment: [balrog] Bug 944075.patch

Added {{ revision['changed_by'] }} in loop.last

Comment 5

[Massimo Gervasini [:massimo]]

Attachment: [balrog] Bug 944075.patch

Updated patch so the most recent release is at the top.

Comment 6

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 8452672 [details] [diff] [review]
[balrog] Bug 944075.patch

lgtm

Comment 7

[[github robot]]

Commit pushed to master at https://github.com/mozilla/balrog

https://github.com/mozilla/balrog/commit/b9ccdd2a12974a7992f411214dfeed29fdcc78f2
Bug 944075 - /revisions/ page doesn't show who made the most recent change to a rule. r=nthomas

Comment 8

[Massimo Gervasini [:massimo]]

Attachment: [balrog] Bug 944075 - remove attribute parameter from sort().patch

Removed attribute='change_id' from sort(). 'attribute' was added in jinja2 and we are using jinjia2 2.5.5

Comment 9

[[github robot]]

Commit pushed to master at https://github.com/mozilla/balrog

https://github.com/mozilla/balrog/commit/ee9d67842d9b251e81dcf3b1e74c55fea4fcac63
Bug 944075 - remove attribute parameter from sort(). r=nthomas

Comment 10

[[e-mail] (:bhearsum)]

Note: this isn't deployed to production yet. It will probably go there today when I land by patch from bug 1013354.

Comment 11

[[e-mail] (:bhearsum)]

This is in production now. Thanks Massimo!