944681 - Keyboard should not fire inputcontextchange on every mouseup event

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Keyboard, defect)

Description

[Jan Jongboom [:janjongboom] (inactive)]

At the moment we fire Forms:Input event from forms.js on every mouseup. That is not correct as we have a separate event to update the selection range already.

Comment 1

[Jan Jongboom [:janjongboom] (inactive)]

Attachment: 944681.patch

Need to have this fixed for cursor positioning.

Comment 2

[Yuan Xulei [:yxl] (Leave from May 18)]

Comment on attachment 8340347 [details] [diff] [review]
944681.patch

Review of attachment 8340347 [details] [diff] [review]:
-----------------------------------------------------------------

r=+ if someone can fix gaia keyboard bug after apply this gecko patch.

The gaia keyboard doesn't listen to the selection change or surroundingtextchange event. If gecko doesn't fire inputcontextchange event when user moves the cursor, the keyboard doesn't know the cursor position is changed and the auto-correction will be wrong.

Comment 3

[Jan Jongboom [:janjongboom] (inactive)]

I'll write a patch.

Comment 4

[Jan Jongboom [:janjongboom] (inactive)]

I don't think this is correct, I checked with this patch and the autocorrect still works, because the gaia keyboard doesn't use any of the events at the moment but keeps state internally.

Rudy, can you confirm?

Comment 5

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Yes, I think right now the buit-in keyboard does not listen to selectionchange or surroundingtextchange and would keep the state internally.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/b2g-inbound/rev/578b2f1504d8

Jan, the name on your patches still isn't importing into hg correctly.

Comment 7

[Jan Jongboom [:janjongboom] (inactive)]

Yeah, sorry, this was still an old style patch. Thanks for landing.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/578b2f1504d8