Closed
Bug 94520
Opened 23 years ago
Closed 23 years ago
ComposerController.js loops too many times
Categories
(Core :: DOM: Editor, defect, P3)
Tracking
()
VERIFIED
FIXED
mozilla0.9.4
People
(Reporter: jdunn, Assigned: sfraser_bugs)
Details
(Whiteboard: needs r=/sr=)
ComposerController's GetEditorController seems to loop 1 to many times thru the list of controllers that it gets. This doesn't really cause any problems, but it is wrong (IMHO). it does a for against numControllers and goes from numControllers down to 0, which means it does 1 too many. Here is my suggested fix. Index: ComposerCommands.js =================================================================== RCS file: /cvsroot/mozilla/editor/ui/composer/content/ComposerCommands.js,v retrieving revision 1.65 diff -u -r1.65 ComposerCommands.js --- ComposerCommands.js 2001/07/06 20:03:40 1.65 +++ ComposerCommands.js 2001/08/09 16:23:08 @@ -179,7 +179,7 @@ var numControllers = window._content.controllers.getControllerCount(); // count down to find a controller that supplies a nsIControllerCommandManager interface - for (var i = numControllers; i >= 0 ; i --) + for (var i = numControllers-1; i >= 0 ; i --) { var commandManager = null;
Comment 1•23 years ago
|
||
this seems reasonable to me, but am reassigning to sfraser for r/sr=
Assignee: beppe → sfraser
Priority: -- → P3
Whiteboard: needs r=/sr=
Target Milestone: --- → mozilla0.9.4
Assignee | ||
Comment 2•23 years ago
|
||
Yeah, I had that fixed in my tree a while back. r/sr=sfraser
fix checked in
Status: NEW → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•