945200 - lock icon shows on non-secure servers when collapsed in folder pane

Status: RESOLVED FIXED

(Thunderbird :: Theme, defect)

Description

[:aceman]

Maybe similar to bug 945024, the folder pane shows wrong icon for a POP3/IMAP account, when there is no connection security (no SSL or STARTTLS in server settings), like this:
- when account is expanded and selected, there is lock icon over the envelope icon (wrong)
- when account is NOT expanded and selected, there is NO lock icon over the envelope icon (good)
- when account is NOT expanded and NOT selected, there is NO lock icon over the envelope icon (good)

A server that does have security set up shows with the lock icon consistently.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: patch

Sh..., not checked the rules for the servers (not observed because I have no unsecure servers) in bug 945024.

This patch adds the open selector to treechildren::-moz-tree-image(folderNameCol, isServer-true) to be more specific.

I also moved all isServer-true to the second position for easier reading and comparing of the rules.

On Linux and Windows files I also the .tabmail-tab rules to the belonging treechildren rules lie they are already on OS X.

On Windows I removed 
.tabmail-tab[type="folder"][ServerType="nntp"] {
  -moz-image-region: rect(0 160px 16px 144px);
}
which pointed to a not existing image-region.

On Linux
.tabmail-tab[type="folder"][IsServer="true"][ServerType="nntp"][IsSecure="true"] {
  list-style-image: url("chrome://messenger/skin/icons/server.png");
  -moz-image-region: rect(0px 64px 16px 80px);
}
was also wrong (64px and 80px where interchanged).

Josiah, I hope you don't mind I have fixed more than the bug needs.

Comment 2

[Josiah Bruner [:jsbruner]]

Comment on attachment 8341064 [details] [diff] [review]
patch

Review of attachment 8341064 [details] [diff] [review]:
-----------------------------------------------------------------

The code looks fine, though I have no secure folders to test on, so I assume you tested. :)

However, I really don't think you should change the folderPane font color in this bug, it seems to stray too far from the description. Your other extra changes are fine though. f+ for now.

r+ if you split the patch and move the font changes to another bug.

Thanks Richard!

::: mail/themes/linux/mail/folderPane.css
@@ +174,5 @@
>  }
>  
>  /* ::::: All Servers ::::: */
>  
> +treechildren::-moz-tree-cell-text(folderNameCol, isServer-true, biffState-NewMail),

Move to a new bug please. I think this strays a little too far from the point of the bug.

@@ +180,5 @@
>  treechildren::-moz-tree-cell-text(folderNameCol, specialFolder-Inbox, newMessages-true) {
>    color: -moz-hyperlinktext;
>  }
>  
> +treechildren::-moz-tree-cell-text(folderNameCol, isServer-true, biffState-NewMail, selected),

Ditto.

@@ +186,5 @@
>  treechildren::-moz-tree-cell-text(folderNameCol, specialFolder-Inbox, newMessages-true, selected) {
>    color: -moz-CellHighlightText;
>  }
>  
> +treechildren::-moz-tree-cell-text(folderNameCol, isServer-true, biffState-NewMail, selected, focus),

Ditto.

::: mail/themes/osx/mail/folderPane.css
@@ +290,5 @@
>  }
>  
>  /* ::::: All Servers ::::: */
>  
> +treechildren::-moz-tree-cell-text(folderNameCol, isServer-true, biffState-NewMail),

Move to a new bug please.

::: mail/themes/windows/mail/folderPane-aero.css
@@ +4,5 @@
>  
>  %include folderPane.css
>  
>  @media all and (-moz-windows-default-theme) {
> +  treechildren::-moz-tree-cell-text(folderNameCol, isServer-true, biffState-NewMail),

Move to a new bug please.

@@ +10,5 @@
>    treechildren::-moz-tree-cell-text(folderNameCol, specialFolder-Inbox, newMessages-true) {
>      color: -moz-hyperlinktext;
>    }
>  
> +  treechildren::-moz-tree-cell-text(folderNameCol, isServer-true, biffState-NewMail, selected),

Ditto.

@@ +16,5 @@
>    treechildren::-moz-tree-cell-text(folderNameCol, specialFolder-Inbox, newMessages-true, selected) {
>      color: -moz-hyperlinktext;
>    }
>  
> +  treechildren::-moz-tree-cell-text(folderNameCol, isServer-true, biffState-NewMail, selected, focus),

Ditto.

::: mail/themes/windows/mail/folderPane.css
@@ +204,5 @@
>  }
>  
>  /* ::::: All Servers ::::: */
>  
> +treechildren::-moz-tree-cell-text(folderNameCol, isServer-true, biffState-NewMail),

Move to a new bug please.

@@ +210,5 @@
>  treechildren::-moz-tree-cell-text(folderNameCol, specialFolder-Inbox, newMessages-true) {
>    color: blue;
>  }
>  
> +treechildren::-moz-tree-cell-text(folderNameCol, isServer-true, biffState-NewMail, selected),

Ditto.

@@ +216,5 @@
>  treechildren::-moz-tree-cell-text(folderNameCol, specialFolder-Inbox, newMessages-true, selected) {
>    color: -moz-CellHighlightText;
>  }
>  
> +treechildren::-moz-tree-cell-text(folderNameCol, isServer-true, biffState-NewMail, selected, focus),

Ditto.

Comment 3

[Richard Marti (:Paenglab)]

Attachment: simpler patch

There was no font color change in old patch but I'm okay to split the cleanup to a new bug.

Comment 4

[Josiah Bruner [:jsbruner]]

Comment on attachment 8341813 [details] [diff] [review]
simpler patch

Review of attachment 8341813 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good!

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/comm-central/rev/e9bc0f80b318