946339 - Tap and hold does not highlight the targeted element

Status: RESOLVED FIXED

(Core :: Panning and Zooming, defect)

Description

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

In BrowserElementPanning.js we used to highlight the element after a certain amount of time.

Comment 1

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Dale told me he may have a chance to look at it. So I'm assigning the bug to him ;)

Comment 2

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Similarly to bug 942856 something has fixed it or will fix it. Hope I don't see it again.

Comment 3

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: wip.one.highlight.for.all.patch

Comment 4

[Dale Harvey (:daleharvey)]

Comment on attachment 8344436 [details] [diff] [review]
wip.one.highlight.for.all.patch

Clearing review as I am not familiar with this code at all, however in testing it is working for me, I find the double active state strange (I get a persistent outline first, then a background if hovering)

Comment 5

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

https://tbpl.mozilla.org/?tree=Try&rev=1bacd4bd77cc

Comment 6

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

https://hg.mozilla.org/integration/b2g-inbound/rev/cb4664b6c3fa

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/cb4664b6c3fa

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/d99b36ffd3a6