Closed
Bug 946486
Opened 11 years ago
Closed 11 years ago
Don't cache "browser.snippets.enabled" value
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 28
People
(Reporter: Margaret, Assigned: Margaret)
References
Details
Attachments
(1 file)
|
2.31 KB,
patch
|
bnicholson
:
review+
|
Details | Diff | Splinter Review |
I know I said before that it was okay to cache this pref value, but if we do that, a bootstrapped add-on can't dynamically set the pref for testing. I made an add-on that enables snippets, and sets the update url to my test snippets server. With this patch applied, it works (although it does still require a restart, probably to force the update timer to fire): http://people.mozilla.org/~mleibovic/testsnippets.xpi
Attachment #8342681 -
Flags: review?(bnicholson)
|
Assignee | |
Updated•11 years ago
|
Assignee: nobody → margaret.leibovic
|
||
Updated•11 years ago
|
Attachment #8342681 -
Flags: review?(bnicholson) → review+
|
||
Updated•11 years ago
|
Status: NEW → ASSIGNED
Hardware: ARM → All
Summary: Don't cache "browser.snippests.enabled" value → Don't cache "browser.snippets.enabled" value
|
|
Assignee | |
Comment 1•11 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/fb87b500de16
|
||
Comment 2•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/fb87b500de16
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 28
|
||
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•