Closed
Bug 946769
Opened 11 years ago
Closed 10 years ago
Trying to fix intermittents in apps/system/test/marionette/edges_gesture_test.js
Categories
(Firefox OS Graveyard :: Gaia::System::Window Mgmt, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: etienne, Assigned: etienne)
References
Details
Attachments
(1 file, 1 obsolete file)
Doesn't happen that often but it can't hut.
Assignee | ||
Updated•11 years ago
|
Blocks: edge-gestures
Assignee | ||
Comment 1•11 years ago
|
||
(test-only diff)
Assignee: nobody → etienne
Attachment #8343140 -
Flags: review?(alive)
Comment 2•11 years ago
|
||
Comment on attachment 8343140 [details] [review] Pointer to gaia PR That sounds a sad bug for marionatte and looks like this may occur to all tests? Can we have a followup bug for guys working on js-marionatte to fix it?
Attachment #8343140 -
Flags: review?(alive) → review+
Assignee | ||
Comment 3•10 years ago
|
||
(In reply to Alive Kuo [:alive][NEEDINFO] from comment #2) > Comment on attachment 8343140 [details] [review] > Pointer to gaia PR > > That sounds a sad bug for marionatte and looks like this may occur to all > tests? > Can we have a followup bug for guys working on js-marionatte to fix it? Yes, I'm mainly waiting to see if this is actually helping :)
Assignee | ||
Comment 4•10 years ago
|
||
> Yes, I'm mainly waiting to see if this is actually helping :)
Apparently it is not :)
(the travis run for the PR had the same intermittent).
Back to the drawing board.
Assignee | ||
Updated•10 years ago
|
Attachment #8343140 -
Attachment is obsolete: true
Assignee | ||
Comment 5•10 years ago
|
||
Mmmhhh... I do have a new idea. will come up with a new patch soon.
Assignee | ||
Comment 6•10 years ago
|
||
Take #2. The suite was failing differently with the previous patch, but the common denominator was that we were always failing at the beginning of a test (where we usually assert that the calendar app is displayed, which is the state at the end of the setup). Now properly waiting for the things to settle at the end of the setup function.
Attachment #8344746 -
Flags: review?(alive)
Comment 7•10 years ago
|
||
Landed to be able to reopen the tree: https://github.com/mozilla-b2g/gaia/commit/e42844c33b961010f797d39527c11bdbd26fab30 Please file followup PR for review comments.
Comment 8•10 years ago
|
||
Comment on attachment 8344746 [details] [review] Gaia PR Landed so canceled
Attachment #8344746 -
Flags: review?(alive)
Assignee | ||
Comment 9•10 years ago
|
||
Comment on attachment 8344746 [details] [review] Gaia PR Not a big deal. But marking this as r=gwagner since Alive didn't got a chance to see the patch before it was landed.
Attachment #8344746 -
Flags: review+
Assignee | ||
Updated•10 years ago
|
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•