Closed
Bug 946970
Opened 11 years ago
Closed 8 years ago
Add support for full zoom via toolkit's ZoomManager
Categories
(Firefox for Metro Graveyard :: Pan and Zoom, defect, P1)
Tracking
(Not tracked)
RESOLVED
INCOMPLETE
People
(Reporter: smaug, Unassigned)
References
()
Details
(Whiteboard: p=5)
Attachments
(1 file, 1 obsolete file)
14.85 KB,
patch
|
Details | Diff | Splinter Review |
Currently zoom doesn't seem to work at all in Metrofox. ctrl+/- or pinch gesture from touchpad don't do anything
Comment 1•11 years ago
|
||
This is expected. We've disabled the old toolkit zoom. To get this working we'll need to hook all the older input shortcuts and up to the apzc, which unfortunately we won't have for fx28.
Updated•11 years ago
|
Blocks: metrobacklog
Comment 2•11 years ago
|
||
(In reply to Jim Mathies [:jimm] from comment #1) > This is expected. We've disabled the old toolkit zoom. To get this working > we'll need to hook all the older input shortcuts and up to the apzc, which > unfortunately we won't have for fx28. Actually, we could just make the keyboard/trackpad/wheel zoom use fullZoom as in desktop Firefox. This is what IE and Chrome do, both on the desktop and in Metro: APZC-style viewport zooming for touch, and desktop-style layout zooming for keyboard/trackpad/wheel.
Comment 3•11 years ago
|
||
(In reply to Matt Brubeck (:mbrubeck) from comment #2) > (In reply to Jim Mathies [:jimm] from comment #1) > > This is expected. We've disabled the old toolkit zoom. To get this working > > we'll need to hook all the older input shortcuts and up to the apzc, which > > unfortunately we won't have for fx28. > > Actually, we could just make the keyboard/trackpad/wheel zoom use fullZoom > as in desktop Firefox. This is what IE and Chrome do, both on the desktop > and in Metro: APZC-style viewport zooming for touch, and desktop-style > layout zooming for keyboard/trackpad/wheel. Didn't we disable page zoom because it was in conflict with apzc zoom? I can't remember the bug number.
Comment 4•11 years ago
|
||
(In reply to Jim Mathies [:jimm] from comment #3) > Didn't we disable page zoom because it was in conflict with apzc zoom? I > can't remember the bug number. We removed the old Control-Plus/Minus shortcuts which used the "AnimatedZoom" class which was how we did viewport zooming before APZC. We can't just restore that old code since it won't work in the APZC world, as you say. We'd add new code that used ZoomManager instead (like desktop Firefox).
Updated•10 years ago
|
Summary: Zoom is disabled in Metrofox → Page zoom is currently disabled in Metro Firefox
Updated•10 years ago
|
Updated•10 years ago
|
Whiteboard: [triage]
Updated•10 years ago
|
Whiteboard: [v1?]
Updated•10 years ago
|
Whiteboard: [v1?] → [feature] p=0
Updated•10 years ago
|
Updated•10 years ago
|
Priority: -- → P1
Whiteboard: [feature] p=0 → p=0
Updated•10 years ago
|
Assignee: nobody → jmathies
Whiteboard: p=0 → p=5
Comment 8•10 years ago
|
||
This works great, except that apzc panning experiences heavy checkerboarding (black rects at the bounds) when zoom is applied.
Comment 9•10 years ago
|
||
You can also apzc zoom pages out that have been zoomed in, and sort of lock them into the center of the screen heavily cropped.
Comment 10•10 years ago
|
||
Although we've tried to write the APZ code so that it works with full zoom, it's quite possible that there are issues there because until now we've never been able to test it.
Updated•10 years ago
|
Summary: Page zoom is currently disabled in Metro Firefox → Add support for font inflation via toolkit's ZoomManager
Comment 11•10 years ago
|
||
(In reply to Kartikaya Gupta (email:kats@mozilla.com) from comment #10) > Although we've tried to write the APZ code so that it works with full zoom, > it's quite possible that there are issues there because until now we've > never been able to test it. now we do! :)
Comment 12•10 years ago
|
||
I'm using the wrong terminology I guess.
Summary: Add support for font inflation via toolkit's ZoomManager → Add support for full zoom via toolkit's ZoomManager
Comment 13•10 years ago
|
||
- added keyboard shortcuts
Attachment #8387568 -
Attachment is obsolete: true
Comment 14•10 years ago
|
||
Hmm, strange, text selection with the mouse has offset coordinates. I'd expect problems with our ui widget positioning, but not with platform code.
Comment 15•10 years ago
|
||
(In reply to Jim Mathies [:jimm] from comment #14) > Hmm, strange, text selection with the mouse has offset coordinates. I'd > expect problems with our ui widget positioning, but not with platform code. Tracked this down, we need to override the fullZoom prop in our bindings so it points to the right nsIMarkupDocumentViewer.
Updated•10 years ago
|
Assignee: jmathies → nobody
Updated•8 years ago
|
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → INCOMPLETE
You need to log in
before you can comment on or make changes to this bug.
Description
•