947271 - Curated group names can break group URLs

Status: VERIFIED FIXED

(Participation Infrastructure :: Phonebook, defect)

Description

[Dan Poirier [:dpoirier]]

On the curatedgroups feature branch, we're no longer creating groups through the groups field on the profile edit page, which was restricting group names to  a pretty minimal character set. On the new group creation form, we're currently allowing most chars in a group name. 

Some of the resulting slugs (the 'url' field on the group), when used to form URLs for the group app, result in complete URLs that don't match the patterns in the group app URL conf. 

For example, you can include ' in a group name (e.g. "Dan's Super Group") and the slug is something like "dan's_super_group", but ' is not matched by the patterns, so when you try to view the group, you get a 404.

We could add validation to the group form to restrict the group names back to what we had before, but that seems overly limiting. I think a better solution would be to allow pretty arbitrary group names, and just improve the code we use to generate the slug (url) so the slugs have the limited character set that'll match our URL patterns.

Comment 1

[Justin Crawford [:hoosteeno] [:jcrawford]]

> I think a better
> solution would be to allow pretty arbitrary group names, and just improve
> the code we use to generate the slug (url) so the slugs have the limited
> character set that'll match our URL patterns.

+1 to this. Thanks!

Comment 2

[Dan Poirier [:dpoirier]]

Pull request https://github.com/mozilla/mozillians/pull/741

Comment 3

[Giorgos Logiotatidis [:giorgos]]

Fixed here:

https://github.com/mozilla/mozillians/commit/4370938ebf87406e9a75a6eee26a14f49d97a776
https://github.com/mozilla/mozillians/commit/e4e2dfd3b99f4424bb4f4c9ffdbc3a429648abb0

Comment 4

[Matt Brandt [:mbrandt]]

Marking verified as [qa-]. I suspect the unit tests coverage is sufficient. If there are manual test cases that I'm missing please unresolve the bug and I'll pounce on it.