947336 - Use more smart pointers in XPCWrappedJS

Status: RESOLVED FIXED

(Core :: XPConnect, defect)

Comment 1

[Andrew McCreight [:mccr8]]

With this, the get forget stuff in SetAggregatedNativeObject may be simplifiable.

Comment 2

[Andrew McCreight [:mccr8]]

This is fairly straightforward.  The only question is what to do with mRoot. This is an owning pointer only when it isn't |this|.  I could change it to be |null| instead of |this|, and make it always owning, and add a half dozen null-checks, but maybe I'll just document the ownership of mRoot instead.

Comment 3

[Andrew McCreight [:mccr8]]

Attachment: part 1 - Make nsXPCWrappedJS::mOuter into a smart pointer.

Comment 4

[Andrew McCreight [:mccr8]]

Attachment: part 2 - Make nsXPCWrappedJS::mClass a smart pointer.

try run: https://tbpl.mozilla.org/?tree=Try&rev=20caa5300e5e

Comment 5

[Andrew McCreight [:mccr8]]

Attachment: part 3 - Add comment about ownership of nsXPCWrappedJS::mRoot.

Comment 6

[Andrew McCreight [:mccr8]]

https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?changeset=bd14c8ecd480

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/5cccbc60db9c
https://hg.mozilla.org/mozilla-central/rev/0c95ce70e969
https://hg.mozilla.org/mozilla-central/rev/060805681c3a